Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLT cmake language suport initialization difference between cuda and hip #609

Open
cyrush opened this issue Dec 2, 2022 · 3 comments
Open
Labels

Comments

@cyrush
Copy link
Member

cyrush commented Dec 2, 2022

BLT calls enable_language(cuda) when cuda is on:

enable_language(CUDA)

However, it doesn't call: enable_language(hip) when hip is on.

We should be consistent.

@cyrush cyrush added the bug label Dec 2, 2022
@cyrush cyrush changed the title BLT cmake languarge suport initialization differnce between cuda and hip BLT cmake language suport initialization differnce between cuda and hip Dec 2, 2022
@cyrush cyrush changed the title BLT cmake language suport initialization differnce between cuda and hip BLT cmake language suport initialization difference between cuda and hip Dec 2, 2022
@cyrush
Copy link
Member Author

cyrush commented Dec 2, 2022

And fun fact:

enable_language(HIP)

(don't tread the lowercase trail)

@skyreflectedinmirrors
Copy link

Also, as of the latest release, the HIP smoke tests are .cpp files (i.e., they expect to be compiled using e.g., CMAKE_CXX_COMPILER=hipcc, or amdclang++ with the right flags set).

If I get around to it, I might take a pass at using HIP language support in BLT.

@skyreflectedinmirrors
Copy link

skyreflectedinmirrors commented Apr 20, 2023

A few question for y'all on HIP-Lang support:

  • Would you expect there to be a new BLT target -- i.e., separate from the existing blt::hip / blt::hip_runtime -- for source files that use the HIP-language (as opposed to hipcc-as-CXX), which would add HIP as the target language to all the SOURCES for that test (etc.) -- this is not ideal, imo as you can have a target that has both CXX/HIP/etc. language files -- OR
  • Would you expect that HIP-language source files conform to the CMAKE_HIP_SOURCE_FILE_EXTENSIONS (i.e., be named source.hip), and/or explicitly set the target language

Additionally, do you think BLT should allow mixing of the 'legacy' HIP target and 'HIP-Language' targets at the same time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants