Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMRAIConfig.cmake should call find_dependency(<thirdparty>) for all third-party packages that SAMRAI uses #225

Open
humhang opened this issue May 7, 2023 · 0 comments

Comments

@humhang
Copy link

humhang commented May 7, 2023

My code uses SAMRAI which is compiled with umpire and RAJA, although my code itself does not use Umpire or RAJA.

In order for my code to compile, I have to explicitly add find_package(umpire) and find_package(RAJA) in my CMakeLists.txt, otherwise the targets of umpire and RAJA will not be imported, and I will have got a linking error. Although I should not need to do this, this should be done by SAMRAIConfig.cmake, the cmake config file of SAMRAI, via find_dependency(umpire) and find_dependency(RAJA), if SAMRAI is compiled with these libraries. This is somehow the standard practice. And downstream codes that use SAMRAI won't need to adjust their CMakeLists.txt depending on the configuration of SAMRAI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant