From 9c0251bde052c0e64e86c96b05365c36e6e40b79 Mon Sep 17 00:00:00 2001 From: Robert Chen Date: Tue, 5 Dec 2023 13:05:14 -0800 Subject: [PATCH 01/31] API and build changes for new SYCL compiler on corona. --- .../lc-builds/toss4/corona_sycl.cmake | 6 ++--- include/RAJA/policy/sycl/reduce.hpp | 22 +++++++++---------- scripts/lc-builds/corona_sycl.sh | 7 +++--- 3 files changed, 18 insertions(+), 17 deletions(-) diff --git a/host-configs/lc-builds/toss4/corona_sycl.cmake b/host-configs/lc-builds/toss4/corona_sycl.cmake index fa15794707..bf1388a78b 100755 --- a/host-configs/lc-builds/toss4/corona_sycl.cmake +++ b/host-configs/lc-builds/toss4/corona_sycl.cmake @@ -10,9 +10,9 @@ set(RAJA_COMPILER "RAJA_COMPILER_CLANG" CACHE STRING "") set(CMAKE_CXX_COMPILER "clang++" CACHE PATH "") #set(CMAKE_CXX_COMPILER "dpcpp" CACHE PATH "") -set(CMAKE_CXX_FLAGS_RELEASE "-O3 -L${SYCL_LIB_PATH} -fsycl -fsycl-unnamed-lambda -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend --offload-arch=gfx90a" CACHE STRING "") -set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O3 -g -L${SYCL_LIB_PATH} -fsycl -fsycl-unnamed-lambda -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend --offload-arch=gfx90a" CACHE STRING "") -set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g -L${SYCL_LIB_PATH} -fsycl -fsycl-unnamed-lambda -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend --offload-arch=gfx90a" CACHE STRING "") +set(CMAKE_CXX_FLAGS_RELEASE "-O3 -L${SYCL_LIB_PATH} -fsycl -fsycl-unnamed-lambda -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend --offload-arch=gfx906" CACHE STRING "") +set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O3 -g -L${SYCL_LIB_PATH} -fsycl -fsycl-unnamed-lambda -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend --offload-arch=gfx906" CACHE STRING "") +set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g -L${SYCL_LIB_PATH} -fsycl -fsycl-unnamed-lambda -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend --offload-arch=gfx906" CACHE STRING "") #set(CMAKE_CXX_FLAGS_RELEASE "-O3 -std=c++17 -fsycl -fsycl-unnamed-lambda --gcc-toolchain=/usr/tce/packages/gcc/gcc-7.1.0" CACHE STRING "") #set(CMAKE_CXX_FLAGS_RELWITHDEBINFO " -O3 -g -std=c++17 -fsycl -fsycl-unnamed-lambda --gcc-toolchain=/usr/tce/packages/gcc/gcc-7.1.0" CACHE STRING "") #set(CMAKE_CXX_FLAGS_DEBUG " -O0 -g -std=c++17 -fsycl -fsycl-unnamed-lambda --gcc-toolchain=/usr/tce/packages/gcc/gcc-7.1.0" CACHE STRING "") diff --git a/include/RAJA/policy/sycl/reduce.hpp b/include/RAJA/policy/sycl/reduce.hpp index 522edd8004..9f7fa45b88 100644 --- a/include/RAJA/policy/sycl/reduce.hpp +++ b/include/RAJA/policy/sycl/reduce.hpp @@ -251,7 +251,7 @@ struct TargetReduce { #ifdef __SYCL_DEVICE_ONLY__ auto i = 0; //__spirv::initLocalInvocationId<1, cl::sycl::id<1>>()[0]; - auto atm = cl::sycl::ext::oneapi::atomic_ref(val.device[i]); + auto atm = ::sycl::atomic_ref(val.device[i]); Reducer{}(atm, rhsVal); return *this; #else @@ -265,7 +265,7 @@ struct TargetReduce { #ifdef __SYCL_DEVICE_ONLY__ auto i = 0; //__spirv::initLocalInvocationId<1, cl::sycl::id<1>>()[0]; - auto atm = cl::sycl::ext::oneapi::atomic_ref(val.device[i]); + auto atm = ::sycl::atomic_ref(val.device[i]); Reducer{}(atm, rhsVal); return *this; #else @@ -423,7 +423,7 @@ class ReduceSum { #ifdef __SYCL_DEVICE_ONLY__ auto i = 0;//__spirv::initLocalInvocationId<1, cl::sycl::id<1>>()[0]; - auto atm = cl::sycl::ext::oneapi::atomic_ref(parent::val.device[i]); + auto atm = ::sycl::atomic_ref(parent::val.device[i]); atm.fetch_add(rhsVal); return *this; #else @@ -449,7 +449,7 @@ class ReduceBitOr { #ifdef __SYCL_DEVICE_ONLY__ auto i = 0;//__spirv::initLocalInvocationId<1, cl::sycl::id<1>>()[0]; - auto atm = cl::sycl::ext::oneapi::atomic_ref(parent::val.device[i]); + auto atm = ::sycl::atomic_ref(parent::val.device[i]); atm |= rhsVal; return *this; #else @@ -463,7 +463,7 @@ class ReduceBitOr { #ifdef __SYCL_DEVICE_ONLY__ auto i = 0;//__spirv::initLocalInvocationId<1, cl::sycl::id<1>>()[0]; - auto atm = cl::sycl::ext::oneapi::atomic_ref(parent::val.device[i]); + auto atm = ::sycl::atomic_ref(parent::val.device[i]); atm |= rhsVal; return *this; #else @@ -489,7 +489,7 @@ class ReduceBitAnd { #ifdef __SYCL_DEVICE_ONLY__ auto i = 0;//__spirv::initLocalInvocationId<1, cl::sycl::id<1>>()[0]; - auto atm = cl::sycl::ext::oneapi::atomic_ref(parent::val.device[i]); + auto atm = ::sycl::atomic_ref(parent::val.device[i]); atm &= rhsVal; return *this; #else @@ -503,7 +503,7 @@ class ReduceBitAnd { #ifdef __SYCL_DEVICE_ONLY__ auto i = 0;//__spirv::initLocalInvocationId<1, cl::sycl::id<1>>()[0]; - auto atm = cl::sycl::ext::oneapi::atomic_ref(parent::val.device[i]); + auto atm = ::sycl::atomic_ref(parent::val.device[i]); atm &= rhsVal; return *this; #else @@ -530,7 +530,7 @@ class ReduceMin { #ifdef __SYCL_DEVICE_ONLY__ auto i = 0;//__spirv::initLocalInvocationId<1, cl::sycl::id<1>>()[0]; - auto atm = cl::sycl::ext::oneapi::atomic_ref(parent::val.device[i]); + auto atm = ::sycl::atomic_ref(parent::val.device[i]); atm.fetch_min(rhsVal); return *this; #else @@ -544,7 +544,7 @@ class ReduceMin { #ifdef __SYCL_DEVICE_ONLY__ auto i = 0;//__spirv::initLocalInvocationId<1, cl::sycl::id<1>>()[0]; - auto atm = cl::sycl::ext::oneapi::atomic_ref(parent::val.device[i]); + auto atm = ::sycl::atomic_ref(parent::val.device[i]); atm.fetch_min(rhsVal); return *this; #else @@ -571,7 +571,7 @@ class ReduceMax { #ifdef __SYCL_DEVICE_ONLY__ auto i = 0;//__spirv::initLocalInvocationId<1, cl::sycl::id<1>>()[0]; - auto atm = cl::sycl::ext::oneapi::atomic_ref(parent::val.device[i]); + auto atm = ::sycl::atomic_ref(parent::val.device[i]); atm.fetch_max(rhsVal); return *this; #else @@ -585,7 +585,7 @@ class ReduceMax { #ifdef __SYCL_DEVICE_ONLY__ auto i = 0;//__spirv::initLocalInvocationId<1, cl::sycl::id<1>>()[0]; - auto atm = cl::sycl::ext::oneapi::atomic_ref(parent::val.device[i]); + auto atm = ::sycl::atomic_ref(parent::val.device[i]); atm.fetch_max(rhsVal); return *this; #else diff --git a/scripts/lc-builds/corona_sycl.sh b/scripts/lc-builds/corona_sycl.sh index 6f344979fb..24f080554e 100755 --- a/scripts/lc-builds/corona_sycl.sh +++ b/scripts/lc-builds/corona_sycl.sh @@ -13,7 +13,7 @@ if [[ $# -lt 1 ]]; then echo " 1) SYCL compiler installation path" echo echo "For example: " - echo " corona_sycl.sh /usr/workspace/raja-dev/clang_sycl_hip_gcc10.2.1_rocm5.1.0/install" + echo " corona_sycl.sh /usr/workspace/raja-dev/clang_sycl_a0117ab8692a_hip_gcc10.2.1_rocm5.6.0" exit fi @@ -36,6 +36,7 @@ mkdir build_${BUILD_SUFFIX}_${USER} && cd build_${BUILD_SUFFIX}_${USER} DATE=$(printf '%(%Y-%m-%d)T\n' -1) export PATH=${SYCL_PATH}/bin:$PATH +export LD_LIBRARY_PATH=${SYCL_PATH}/lib:${SYCL_PATH}/lib64:$LD_LIBRARY_PATH ## NOTE: RAJA tests are turned off due to compilation issues. @@ -51,8 +52,8 @@ cmake \ -DCMAKE_C_COMPILER=clang \ -DCMAKE_CXX_COMPILER=clang++ \ -DCMAKE_LINKER=clang++ \ - -DCMAKE_CXX_STANDARD=17 \ - -DENABLE_TESTS=Off \ + -DBLT_CXX_STD=17 \ + -DENABLE_TESTS=On \ -DENABLE_EXAMPLES=On \ "$@" \ .. From 60116813191702adf4fb751c4f11c15d55461cf2 Mon Sep 17 00:00:00 2001 From: Robert Chen Date: Tue, 5 Dec 2023 14:47:50 -0800 Subject: [PATCH 02/31] Correct BLT std for Corona. --- scripts/lc-builds/corona_sycl.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/lc-builds/corona_sycl.sh b/scripts/lc-builds/corona_sycl.sh index 24f080554e..7ce6ee5f0d 100755 --- a/scripts/lc-builds/corona_sycl.sh +++ b/scripts/lc-builds/corona_sycl.sh @@ -52,7 +52,7 @@ cmake \ -DCMAKE_C_COMPILER=clang \ -DCMAKE_CXX_COMPILER=clang++ \ -DCMAKE_LINKER=clang++ \ - -DBLT_CXX_STD=17 \ + -DBLT_CXX_STD=c++17 \ -DENABLE_TESTS=On \ -DENABLE_EXAMPLES=On \ "$@" \ From e266014852213cb67e5e6e925c8289a439fc524f Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Mon, 4 Mar 2024 15:07:01 +0100 Subject: [PATCH 03/31] Update RADIUSS Spack Configs with February 2024 release changes --- scripts/radiuss-spack-configs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/radiuss-spack-configs b/scripts/radiuss-spack-configs index a37c3e1906..12fd9cfd57 160000 --- a/scripts/radiuss-spack-configs +++ b/scripts/radiuss-spack-configs @@ -1 +1 @@ -Subproject commit a37c3e1906baef912c59f3ef52aa45ab71cab0be +Subproject commit 12fd9cfd57c11ed0c961234833a4a8a89cefd491 From ac9fffbc0bb85551311592a8bbbb090b7adc526d Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Mon, 4 Mar 2024 16:49:54 +0100 Subject: [PATCH 04/31] Fix draft PR filter --- .gitlab-ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 783309eb2e..a28d27ca53 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -75,7 +75,7 @@ stages: include: - local: '.gitlab/custom-jobs-and-variables.yml' - project: 'radiuss/radiuss-shared-ci' - ref: 'v2023.12.0' + ref: 'woptim/draft-filter-fix' file: 'pipelines/${CI_MACHINE}.yml' - artifact: '${CI_MACHINE}-jobs.yml' job: 'generate-job-lists' @@ -102,7 +102,9 @@ trigger-rajaperf: include: # [Optional] checks preliminary to running the actual CI test - project: 'radiuss/radiuss-shared-ci' - ref: 'v2023.12.0' + ref: 'woptim/draft-filter-fix' file: 'utilities/preliminary-ignore-draft-pr.yml' # pipelines subscribed by the project - local: '.gitlab/subscribed-pipelines.yml' + +# THIS WILL BE A DRAFT, REMOVE THIS LINE AFTER FIRST CI RUN. From cf79c9945888ca4dd6095a0ea46e7eb67fb403b8 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Mon, 4 Mar 2024 17:11:43 +0100 Subject: [PATCH 05/31] re-run --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index a28d27ca53..54f1985515 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -107,4 +107,4 @@ include: # pipelines subscribed by the project - local: '.gitlab/subscribed-pipelines.yml' -# THIS WILL BE A DRAFT, REMOVE THIS LINE AFTER FIRST CI RUN. +# THIS WILL BE A DRAFT, REMOVE THIS LINE AFTER FIRST CI RUN (V2). From add314023b7d3758cc920958f1bafb0309162298 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Mon, 4 Mar 2024 17:14:43 +0100 Subject: [PATCH 06/31] Not a draft anymore --- .gitlab-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 54f1985515..27b12a236b 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -106,5 +106,3 @@ include: file: 'utilities/preliminary-ignore-draft-pr.yml' # pipelines subscribed by the project - local: '.gitlab/subscribed-pipelines.yml' - -# THIS WILL BE A DRAFT, REMOVE THIS LINE AFTER FIRST CI RUN (V2). From 95f044238f2224654651c8f9d05a045af681c939 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Mon, 4 Mar 2024 21:01:20 +0100 Subject: [PATCH 07/31] Update syntax for Shared CI 2023.12.1-2 --- .gitlab/jobs/corona.yml | 3 ++- .gitlab/jobs/lassen.yml | 3 ++- .gitlab/jobs/poodle.yml | 3 ++- .gitlab/jobs/ruby.yml | 3 ++- .gitlab/jobs/tioga.yml | 3 ++- 5 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.gitlab/jobs/corona.yml b/.gitlab/jobs/corona.yml index b483bb6ffb..6df0788ee1 100644 --- a/.gitlab/jobs/corona.yml +++ b/.gitlab/jobs/corona.yml @@ -6,7 +6,8 @@ ############################################################################# # Override reproducer section to define project specific variables. -.corona_reproducer_vars: &corona_reproducer_vars +.corona_reproducer_vars: + script: - | echo -e "export MODULE_LIST=\"${MODULE_LIST}\"" echo -e "export SPEC=\"${SPEC//\"/\\\"}\"" diff --git a/.gitlab/jobs/lassen.yml b/.gitlab/jobs/lassen.yml index 4a17ee2f86..5e04c50126 100644 --- a/.gitlab/jobs/lassen.yml +++ b/.gitlab/jobs/lassen.yml @@ -6,7 +6,8 @@ ############################################################################## # Override reproducer section to define project specific variables. -.lassen_reproducer_vars: &lassen_reproducer_vars +.lassen_reproducer_vars: + script: - | echo -e "export MODULE_LIST=\"${MODULE_LIST}\"" echo -e "export SPEC=\"${SPEC//\"/\\\"}\"" diff --git a/.gitlab/jobs/poodle.yml b/.gitlab/jobs/poodle.yml index 1b5f86aa4a..6edafdb0fa 100644 --- a/.gitlab/jobs/poodle.yml +++ b/.gitlab/jobs/poodle.yml @@ -6,7 +6,8 @@ ############################################################################## # Override reproducer section to define projet specific variables. -.poodle_reproducer_vars: &poodle_reproducer_vars +.poodle_reproducer_vars: + script: - | echo -e "export MODULE_LIST=\"${MODULE_LIST}\"" echo -e "export SPEC=\"${SPEC//\"/\\\"}\"" diff --git a/.gitlab/jobs/ruby.yml b/.gitlab/jobs/ruby.yml index 7a42a815e7..3b86a36c13 100644 --- a/.gitlab/jobs/ruby.yml +++ b/.gitlab/jobs/ruby.yml @@ -6,7 +6,8 @@ ############################################################################## # Override reproducer section to define project specific variables. -.ruby_reproducer_vars: &ruby_reproducer_vars +.ruby_reproducer_vars: + script: - | echo -e "export MODULE_LIST=\"${MODULE_LIST}\"" echo -e "export SPEC=\"${SPEC//\"/\\\"}\"" diff --git a/.gitlab/jobs/tioga.yml b/.gitlab/jobs/tioga.yml index a59af625a3..e879bd7766 100644 --- a/.gitlab/jobs/tioga.yml +++ b/.gitlab/jobs/tioga.yml @@ -6,7 +6,8 @@ ############################################################################# # Override reproducer section to define project specific variables. -.tioga_reproducer_vars: &tioga_reproducer_vars +.tioga_reproducer_vars: + script: - | echo -e "export MODULE_LIST=\"${MODULE_LIST}\"" echo -e "export SPEC=\"${SPEC//\"/\\\"}\"" From 66c7ad4be64b3854005daffa07325b7bd11801a9 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Tue, 5 Mar 2024 16:42:26 +0100 Subject: [PATCH 08/31] A test (to revert) --- .gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 27b12a236b..cf7f90f229 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -106,3 +106,5 @@ include: file: 'utilities/preliminary-ignore-draft-pr.yml' # pipelines subscribed by the project - local: '.gitlab/subscribed-pipelines.yml' + +# ADD A TAG TO TEST WHETHER GITLAB GETS FOOLED BY IT OR NOT From 6695310e106320836e0a02aa0e69627847096cf9 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Tue, 5 Mar 2024 17:55:21 +0100 Subject: [PATCH 09/31] Revert "A test (to revert)" This reverts commit 66c7ad4be64b3854005daffa07325b7bd11801a9. --- .gitlab-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index cf7f90f229..27b12a236b 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -106,5 +106,3 @@ include: file: 'utilities/preliminary-ignore-draft-pr.yml' # pipelines subscribed by the project - local: '.gitlab/subscribed-pipelines.yml' - -# ADD A TAG TO TEST WHETHER GITLAB GETS FOOLED BY IT OR NOT From 10a9bf8e7334df3df4fb2a9a03e854b44ce30fc4 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Tue, 5 Mar 2024 12:03:26 +0100 Subject: [PATCH 10/31] Update Spack with fix for https://github.com/spack/spack/issues/42679 --- .uberenv_config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.uberenv_config.json b/.uberenv_config.json index 65474d1ea1..6e5bbef7ae 100644 --- a/.uberenv_config.json +++ b/.uberenv_config.json @@ -4,7 +4,7 @@ "package_final_phase" : "initconfig", "package_source_dir" : "../..", "spack_url": "https://github.com/spack/spack.git", -"spack_branch": "develop-2024-01-21", +"spack_branch": "develop-2024-03-03", "spack_activate" : {}, "spack_configs_path": "scripts/radiuss-spack-configs", "spack_packages_path": "scripts/radiuss-spack-configs/packages", From b77de72a70220e4f3116fda279690106a663fab8 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Wed, 6 Mar 2024 16:49:10 +0100 Subject: [PATCH 11/31] Local and from RSC: Protect compiler version in CI spec --- .gitlab/jobs/corona.yml | 2 +- .gitlab/jobs/lassen.yml | 12 ++++++------ .gitlab/jobs/poodle.yml | 14 +++++++------- .gitlab/jobs/ruby.yml | 14 +++++++------- .gitlab/jobs/tioga.yml | 4 ++-- scripts/radiuss-spack-configs | 2 +- 6 files changed, 24 insertions(+), 24 deletions(-) diff --git a/.gitlab/jobs/corona.yml b/.gitlab/jobs/corona.yml index b483bb6ffb..a774be3b61 100644 --- a/.gitlab/jobs/corona.yml +++ b/.gitlab/jobs/corona.yml @@ -29,6 +29,6 @@ rocmcc_5_7_0_hip_desul_atomics: variables: - SPEC: " ~shared +rocm ~openmp +tests +desul amdgpu_target=gfx906 %rocmcc@5.7.0 ^hip@5.7.0 ^blt@develop" + SPEC: " ~shared +rocm ~openmp +tests +desul amdgpu_target=gfx906 %rocmcc@=5.7.0 ^hip@5.7.0 ^blt@develop" extends: .job_on_corona diff --git a/.gitlab/jobs/lassen.yml b/.gitlab/jobs/lassen.yml index 4a17ee2f86..45766c9778 100644 --- a/.gitlab/jobs/lassen.yml +++ b/.gitlab/jobs/lassen.yml @@ -22,7 +22,7 @@ # Warning: allowed to fail because of a bug in Spack > 0.20.3 xl_2022_08_19_gcc_8_3_1_cuda_11_2_0: variables: - SPEC: "${PROJECT_LASSEN_VARIANTS} +cuda cxxflags==\"-qthreaded -std=c++14 -O3 -qstrict -qxlcompatmacros -qlanglvl=extended0x -qalias=noansi -qhot -qpic -qsmp=omp -qsuppress=1500-029 -qsuppress=1500-036\" %xl@16.1.1.12.gcc.8.3.1 ^cuda@11.2.0+allow-unsupported-compilers ${PROJECT_LASSEN_DEPS} ^blt@develop" + SPEC: "${PROJECT_LASSEN_VARIANTS} +cuda cxxflags==\"-qthreaded -std=c++14 -O3 -qstrict -qxlcompatmacros -qlanglvl=extended0x -qalias=noansi -qhot -qpic -qsmp=omp -qsuppress=1500-029 -qsuppress=1500-036\" %xl@=16.1.1.12.gcc.8.3.1 ^cuda@11.2.0+allow-unsupported-compilers ${PROJECT_LASSEN_DEPS} ^blt@develop" MODULE_LIST: "cuda/11.2.0" LASSEN_JOB_ALLOC: "1 -W 60 -q pci" extends: .job_on_lassen @@ -37,13 +37,13 @@ xl_2022_08_19_gcc_8_3_1_cuda_11_2_0: gcc_8_3_1_omptask: variables: - SPEC: " ~shared +openmp +omptask +tests %gcc@8.3.1 ^blt@develop" + SPEC: " ~shared +openmp +omptask +tests %gcc@=8.3.1 ^blt@develop" extends: .job_on_lassen gcc_8_3_1_cuda_11_5_0_ats_disabled: extends: .job_on_lassen variables: - SPEC: " ~shared +openmp +tests +cuda %gcc@8.3.1 cuda_arch=70 ^cuda@11.5.0+allow-unsupported-compilers ^blt@develop" + SPEC: " ~shared +openmp +tests +cuda %gcc@=8.3.1 cuda_arch=70 ^cuda@11.5.0+allow-unsupported-compilers ^blt@develop" MODULE_LIST: "cuda/11.5.0" LASSEN_JOB_ALLOC: "1 --atsdisable -W 30 -q pci" @@ -53,17 +53,17 @@ gcc_8_3_1_cuda_11_5_0_ats_disabled: clang_13_0_1_libcpp: variables: - SPEC: " ~shared +openmp +tests %clang@13.0.1 cflags==\"-DGTEST_HAS_CXXABI_H_=0\" cxxflags==\"-stdlib=libc++ -DGTEST_HAS_CXXABI_H_=0\" ^blt@develop" + SPEC: " ~shared +openmp +tests %clang@=13.0.1 cflags==\"-DGTEST_HAS_CXXABI_H_=0\" cxxflags==\"-stdlib=libc++ -DGTEST_HAS_CXXABI_H_=0\" ^blt@develop" extends: .job_on_lassen #clang_14_0_5_asan: # variables: -# SPEC: " ~shared +openmp +tests %clang@14.0.5 cxxflags==\"-fsanitize=address\" " +# SPEC: " ~shared +openmp +tests %clang@=14.0.5 cxxflags==\"-fsanitize=address\" " # ASAN_OPTIONS: "detect_leaks=1" # LSAN_OPTIONS: "suppressions=${CI_PROJECT_DIR}/suppressions.asan" # extends: .job_on_lassen gcc_8_3_1_cuda_10_1_243_desul_atomics: variables: - SPEC: " ~shared +openmp +tests +cuda +desul %gcc@8.3.1 cuda_arch=70 ^cuda@10.1.243+allow-unsupported-compilers ^blt@develop" + SPEC: " ~shared +openmp +tests +cuda +desul %gcc@=8.3.1 cuda_arch=70 ^cuda@10.1.243+allow-unsupported-compilers ^blt@develop" extends: .job_on_lassen diff --git a/.gitlab/jobs/poodle.yml b/.gitlab/jobs/poodle.yml index 1b5f86aa4a..cc918b4909 100644 --- a/.gitlab/jobs/poodle.yml +++ b/.gitlab/jobs/poodle.yml @@ -20,24 +20,24 @@ clang_14_0_6: variables: - SPEC: " ~shared +openmp +omptask +tests %clang@14.0.6 ^blt@develop" + SPEC: " ~shared +openmp +omptask +tests %clang@=14.0.6 ^blt@develop" extends: .job_on_poodle gcc_10_3_1: variables: - SPEC: " ~shared +openmp +omptask +tests %gcc@10.3.1 ^blt@develop" + SPEC: " ~shared +openmp +omptask +tests %gcc@=10.3.1 ^blt@develop" POODLE_JOB_ALLOC: "--time=60 --nodes=1" extends: .job_on_poodle intel_19_1_2_gcc_10_3_1: variables: - SPEC: " ~shared +openmp +omptask +tests %intel@19.1.2.gcc.10.3.1 ^blt@develop" + SPEC: " ~shared +openmp +omptask +tests %intel@=19.1.2.gcc.10.3.1 ^blt@develop" POODLE_JOB_ALLOC: "--time=90 --nodes=1" extends: .job_on_poodle intel_2022_1_0: variables: - SPEC: "${PROJECT_POODLE_VARIANTS} %intel@2022.1.0 ${PROJECT_POODLE_DEPS} ^blt@develop" + SPEC: "${PROJECT_POODLE_VARIANTS} %intel@=2022.1.0 ${PROJECT_POODLE_DEPS} ^blt@develop" allow_failure: true extends: .job_on_poodle @@ -50,17 +50,17 @@ intel_2022_1_0: clang_14_0_6_openmp_off: variables: - SPEC: " ~shared ~openmp +tests %clang@14.0.6 ^blt@develop" + SPEC: " ~shared ~openmp +tests %clang@=14.0.6 ^blt@develop" extends: .job_on_poodle gcc_10_3_1_openmp_default: variables: - SPEC: " ~shared +tests %gcc@10.3.1 ^blt@develop" + SPEC: " ~shared +tests %gcc@=10.3.1 ^blt@develop" POODLE_JOB_ALLOC: "--time=60 --nodes=1" extends: .job_on_poodle # OTHERS clang_14_0_6_gcc_10_3_1_desul_atomics: variables: - SPEC: " ~shared +openmp +tests +desul %clang@14.0.6.gcc.10.3.1 ^blt@develop" + SPEC: " ~shared +openmp +tests +desul %clang@=14.0.6.gcc.10.3.1 ^blt@develop" extends: .job_on_poodle diff --git a/.gitlab/jobs/ruby.yml b/.gitlab/jobs/ruby.yml index 7a42a815e7..5a411099b6 100644 --- a/.gitlab/jobs/ruby.yml +++ b/.gitlab/jobs/ruby.yml @@ -20,24 +20,24 @@ clang_14_0_6: variables: - SPEC: " ~shared +openmp +omptask +tests %clang@14.0.6 ^blt@develop" + SPEC: " ~shared +openmp +omptask +tests %clang@=14.0.6 ^blt@develop" extends: .job_on_ruby gcc_10_3_1: variables: - SPEC: " ~shared +openmp +omptask +tests %gcc@10.3.1 ^blt@develop" + SPEC: " ~shared +openmp +omptask +tests %gcc@=10.3.1 ^blt@develop" RUBY_JOB_ALLOC: "--time=60 --nodes=1" extends: .job_on_ruby intel_19_1_2_gcc_10_3_1: variables: - SPEC: " ~shared +openmp +omptask +tests %intel@19.1.2.gcc.10.3.1 ^blt@develop" + SPEC: " ~shared +openmp +omptask +tests %intel@=19.1.2.gcc.10.3.1 ^blt@develop" RUBY_JOB_ALLOC: "--time=90 --nodes=1" extends: .job_on_ruby intel_2022_1_0: variables: - SPEC: "${PROJECT_RUBY_VARIANTS} %intel@2022.1.0 ${PROJECT_RUBY_DEPS} ^blt@develop" + SPEC: "${PROJECT_RUBY_VARIANTS} %intel@=2022.1.0 ${PROJECT_RUBY_DEPS} ^blt@develop" allow_failure: true extends: .job_on_ruby @@ -50,17 +50,17 @@ intel_2022_1_0: clang_14_0_6_openmp_off: variables: - SPEC: " ~shared ~openmp +tests %clang@14.0.6 ^blt@develop" + SPEC: " ~shared ~openmp +tests %clang@=14.0.6 ^blt@develop" extends: .job_on_ruby gcc_10_3_1_openmp_default: variables: - SPEC: " ~shared +tests %gcc@10.3.1 ^blt@develop" + SPEC: " ~shared +tests %gcc@=10.3.1 ^blt@develop" RUBY_JOB_ALLOC: "--time=60 --nodes=1" extends: .job_on_ruby # OTHERS clang_14_0_6_gcc_10_3_1_desul_atomics: variables: - SPEC: " ~shared +openmp +tests +desul %clang@14.0.6.gcc.10.3.1 ^blt@develop" + SPEC: " ~shared +openmp +tests +desul %clang@=14.0.6.gcc.10.3.1 ^blt@develop" extends: .job_on_ruby diff --git a/.gitlab/jobs/tioga.yml b/.gitlab/jobs/tioga.yml index a59af625a3..3a42f5d437 100644 --- a/.gitlab/jobs/tioga.yml +++ b/.gitlab/jobs/tioga.yml @@ -29,10 +29,10 @@ rocmcc_5_7_1_hip_desul_atomics: variables: - SPEC: "~shared +rocm ~openmp +desul +tests amdgpu_target=gfx90a %rocmcc@5.7.1 ^hip@5.7.1 ^blt@develop" + SPEC: "~shared +rocm ~openmp +desul +tests amdgpu_target=gfx90a %rocmcc@=5.7.1 ^hip@5.7.1 ^blt@develop" extends: .job_on_tioga rocmcc_5_7_1_hip_openmp: variables: - SPEC: "~shared +rocm +openmp +omptask +tests amdgpu_target=gfx90a %rocmcc@5.7.1 ^hip@5.7.1 ^blt@develop" + SPEC: "~shared +rocm +openmp +omptask +tests amdgpu_target=gfx90a %rocmcc@=5.7.1 ^hip@5.7.1 ^blt@develop" extends: .job_on_tioga diff --git a/scripts/radiuss-spack-configs b/scripts/radiuss-spack-configs index 12fd9cfd57..1e87bc15be 160000 --- a/scripts/radiuss-spack-configs +++ b/scripts/radiuss-spack-configs @@ -1 +1 @@ -Subproject commit 12fd9cfd57c11ed0c961234833a4a8a89cefd491 +Subproject commit 1e87bc15bef26607838a8854c42b99ba06479c48 From 2231ca87ded07660039b7408a5c367d83fcc631c Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Fri, 8 Mar 2024 10:56:08 +0100 Subject: [PATCH 12/31] Point Shared CI at latest release with draft filter fix --- .gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 27b12a236b..8c1f7a472e 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -75,7 +75,7 @@ stages: include: - local: '.gitlab/custom-jobs-and-variables.yml' - project: 'radiuss/radiuss-shared-ci' - ref: 'woptim/draft-filter-fix' + ref: 'v2023.12.3' file: 'pipelines/${CI_MACHINE}.yml' - artifact: '${CI_MACHINE}-jobs.yml' job: 'generate-job-lists' @@ -102,7 +102,7 @@ trigger-rajaperf: include: # [Optional] checks preliminary to running the actual CI test - project: 'radiuss/radiuss-shared-ci' - ref: 'woptim/draft-filter-fix' + ref: 'v2023.12.3' file: 'utilities/preliminary-ignore-draft-pr.yml' # pipelines subscribed by the project - local: '.gitlab/subscribed-pipelines.yml' From 368cb3e6901f40fefc6b0f83cc55038d5fa3da17 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Fri, 8 Mar 2024 17:23:18 +0100 Subject: [PATCH 13/31] Use another Spack tag to avoid a bug with flag stacking in concretization --- .uberenv_config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.uberenv_config.json b/.uberenv_config.json index 6e5bbef7ae..2261a80aea 100644 --- a/.uberenv_config.json +++ b/.uberenv_config.json @@ -4,7 +4,7 @@ "package_final_phase" : "initconfig", "package_source_dir" : "../..", "spack_url": "https://github.com/spack/spack.git", -"spack_branch": "develop-2024-03-03", +"spack_branch": "develop-2024-02-18", "spack_activate" : {}, "spack_configs_path": "scripts/radiuss-spack-configs", "spack_packages_path": "scripts/radiuss-spack-configs/packages", From 20b614b4adbecba1988d7615c4857e81bc346e4f Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Mon, 11 Mar 2024 16:15:13 +0100 Subject: [PATCH 14/31] Update RSC to main --- scripts/radiuss-spack-configs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/radiuss-spack-configs b/scripts/radiuss-spack-configs index 1e87bc15be..8c115b6a49 160000 --- a/scripts/radiuss-spack-configs +++ b/scripts/radiuss-spack-configs @@ -1 +1 @@ -Subproject commit 1e87bc15bef26607838a8854c42b99ba06479c48 +Subproject commit 8c115b6a49cfc8dd9ed8037bc601b73d1da58966 From aaaaba3b2e8ec770f749ce8aeb100e27ad8eba75 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Mon, 11 Mar 2024 16:29:26 +0100 Subject: [PATCH 15/31] From RSC: fix syntax coherency in compilers definition --- scripts/radiuss-spack-configs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/radiuss-spack-configs b/scripts/radiuss-spack-configs index 8c115b6a49..af75606a7f 160000 --- a/scripts/radiuss-spack-configs +++ b/scripts/radiuss-spack-configs @@ -1 +1 @@ -Subproject commit 8c115b6a49cfc8dd9ed8037bc601b73d1da58966 +Subproject commit af75606a7fc0492e35cdd3860337c4e873f43124 From a9abb8547f19e3e23f19101863fe367f11847bee Mon Sep 17 00:00:00 2001 From: "Richard D. Hornung" Date: Tue, 12 Mar 2024 11:01:26 -0700 Subject: [PATCH 16/31] Add some info to script for running code. --- scripts/lc-builds/corona_sycl.sh | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/scripts/lc-builds/corona_sycl.sh b/scripts/lc-builds/corona_sycl.sh index 9f6b3337a4..d9b98e540c 100755 --- a/scripts/lc-builds/corona_sycl.sh +++ b/scripts/lc-builds/corona_sycl.sh @@ -9,7 +9,7 @@ if [[ $# -lt 1 ]]; then echo - echo "You must pass 1 argument to the script (in this order): " + echo "You must pass 1 argument to the script: " echo " 1) SYCL compiler installation path" echo echo "For example: " @@ -60,9 +60,13 @@ cmake \ echo echo "***********************************************************************" -echo -echo "Remember to export PATH=${SYCL_PATH}/bin:\$PATH to obtain the correct compiler paths." -echo +echo echo "cd into directory build_${BUILD_SUFFIX}_${USER} and run make to build RAJA" +echo +echo "To run RAJA tests, exercises, etc. with the build, please set the" +echo "LD_LIBRARY_PATH environment variable to " +echo " ${SYCL_PATH}/lib:${SYCL_PATH}/lib64:$LD_LIBRARY_PATH" +echo +echo "where SYCL_PATH is the compiler installation path you passed to this script." echo echo "***********************************************************************" From 4fdb5aa15783d7e0f5d0ce2dfb9ab20901944a98 Mon Sep 17 00:00:00 2001 From: Rich Hornung Date: Wed, 13 Mar 2024 13:44:51 -0700 Subject: [PATCH 17/31] increase poodle job time for intel b/c it regularly times out --- .gitlab/jobs/poodle.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/jobs/poodle.yml b/.gitlab/jobs/poodle.yml index 486fdf4121..734f72d336 100644 --- a/.gitlab/jobs/poodle.yml +++ b/.gitlab/jobs/poodle.yml @@ -33,7 +33,7 @@ gcc_10_3_1: intel_19_1_2_gcc_10_3_1: variables: SPEC: " ~shared +openmp +omptask +tests %intel@=19.1.2.gcc.10.3.1 ^blt@develop" - POODLE_JOB_ALLOC: "--time=90 --nodes=1" + POODLE_JOB_ALLOC: "--time=100 --nodes=1" extends: .job_on_poodle intel_2022_1_0: From 069445fdec7e0d479ea52260a381b1a32f1785c8 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Thu, 14 Mar 2024 10:58:49 +0100 Subject: [PATCH 18/31] Remove every job alloc overridding or ruby and poodle: may have been causing job timeouts --- .gitlab/jobs/poodle.yml | 3 --- .gitlab/jobs/ruby.yml | 3 --- 2 files changed, 6 deletions(-) diff --git a/.gitlab/jobs/poodle.yml b/.gitlab/jobs/poodle.yml index 734f72d336..cc1f956cb9 100644 --- a/.gitlab/jobs/poodle.yml +++ b/.gitlab/jobs/poodle.yml @@ -27,13 +27,11 @@ clang_14_0_6: gcc_10_3_1: variables: SPEC: " ~shared +openmp +omptask +tests %gcc@=10.3.1 ^blt@develop" - POODLE_JOB_ALLOC: "--time=60 --nodes=1" extends: .job_on_poodle intel_19_1_2_gcc_10_3_1: variables: SPEC: " ~shared +openmp +omptask +tests %intel@=19.1.2.gcc.10.3.1 ^blt@develop" - POODLE_JOB_ALLOC: "--time=100 --nodes=1" extends: .job_on_poodle intel_2022_1_0: @@ -57,7 +55,6 @@ clang_14_0_6_openmp_off: gcc_10_3_1_openmp_default: variables: SPEC: " ~shared +tests %gcc@=10.3.1 ^blt@develop" - POODLE_JOB_ALLOC: "--time=60 --nodes=1" extends: .job_on_poodle # OTHERS diff --git a/.gitlab/jobs/ruby.yml b/.gitlab/jobs/ruby.yml index 94e4c33754..a924ddd47c 100644 --- a/.gitlab/jobs/ruby.yml +++ b/.gitlab/jobs/ruby.yml @@ -27,13 +27,11 @@ clang_14_0_6: gcc_10_3_1: variables: SPEC: " ~shared +openmp +omptask +tests %gcc@=10.3.1 ^blt@develop" - RUBY_JOB_ALLOC: "--time=60 --nodes=1" extends: .job_on_ruby intel_19_1_2_gcc_10_3_1: variables: SPEC: " ~shared +openmp +omptask +tests %intel@=19.1.2.gcc.10.3.1 ^blt@develop" - RUBY_JOB_ALLOC: "--time=90 --nodes=1" extends: .job_on_ruby intel_2022_1_0: @@ -57,7 +55,6 @@ clang_14_0_6_openmp_off: gcc_10_3_1_openmp_default: variables: SPEC: " ~shared +tests %gcc@=10.3.1 ^blt@develop" - RUBY_JOB_ALLOC: "--time=60 --nodes=1" extends: .job_on_ruby # OTHERS From b3e7d1d97226d53405c6ebe81d8829f2c71a99ae Mon Sep 17 00:00:00 2001 From: Rich Hornung Date: Thu, 14 Mar 2024 08:56:49 -0700 Subject: [PATCH 19/31] increase time for shared alloc on poodle --- .gitlab/custom-jobs-and-variables.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/custom-jobs-and-variables.yml b/.gitlab/custom-jobs-and-variables.yml index 040449be69..479bfbbc16 100644 --- a/.gitlab/custom-jobs-and-variables.yml +++ b/.gitlab/custom-jobs-and-variables.yml @@ -25,7 +25,7 @@ variables: # Poodle # Arguments for top level allocation - POODLE_SHARED_ALLOC: "--exclusive --time=40 --nodes=1" + POODLE_SHARED_ALLOC: "--exclusive --time=60 --nodes=1" # Arguments for job level allocation POODLE_JOB_ALLOC: "--overlap --nodes=1" # Project specific variants for poodle From 1c446a6e67f9812c2c1135c8c4f7cec8bb852994 Mon Sep 17 00:00:00 2001 From: "Richard D. Hornung" Date: Thu, 14 Mar 2024 09:58:38 -0700 Subject: [PATCH 20/31] Add more details to script --- scripts/lc-builds/corona_sycl.sh | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/scripts/lc-builds/corona_sycl.sh b/scripts/lc-builds/corona_sycl.sh index d9b98e540c..f5fdf02adb 100755 --- a/scripts/lc-builds/corona_sycl.sh +++ b/scripts/lc-builds/corona_sycl.sh @@ -62,11 +62,16 @@ echo echo "***********************************************************************" echo echo "cd into directory build_${BUILD_SUFFIX}_${USER} and run make to build RAJA" -echo -echo "To run RAJA tests, exercises, etc. with the build, please set the" -echo "LD_LIBRARY_PATH environment variable to " -echo " ${SYCL_PATH}/lib:${SYCL_PATH}/lib64:$LD_LIBRARY_PATH" -echo -echo "where SYCL_PATH is the compiler installation path you passed to this script." +echo +echo "To run RAJA tests, exercises, etc. with the build, please do the following:" +echo +echo " 1) Load the ROCm module version matching the version in the compiler path" +echo " you passed to this script." +echo +echo " 2) Set the "LD_LIBRARY_PATH environment variable to " +echo " ${SYCL_PATH}/lib:${SYCL_PATH}/lib64:${LD_LIBRARY_PATH}" +echo +echo " where SYCL_PATH is set to the compiler installation path you passed" +echo " to this script." echo echo "***********************************************************************" From 02e37f9bf35bb85ac2434d84978cae42c3d6c234 Mon Sep 17 00:00:00 2001 From: Rich Hornung Date: Thu, 14 Mar 2024 12:59:52 -0700 Subject: [PATCH 21/31] Bump GitLab CI shared alloc times to hopefully prevent timeouts --- .gitlab/custom-jobs-and-variables.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab/custom-jobs-and-variables.yml b/.gitlab/custom-jobs-and-variables.yml index 479bfbbc16..39dbda4300 100644 --- a/.gitlab/custom-jobs-and-variables.yml +++ b/.gitlab/custom-jobs-and-variables.yml @@ -14,7 +14,7 @@ variables: # Ruby # Arguments for top level allocation - RUBY_SHARED_ALLOC: "--exclusive --reservation=ci --time=30 --nodes=2" + RUBY_SHARED_ALLOC: "--exclusive --reservation=ci --time=40 --nodes=2" # Arguments for job level allocation # Note: We repeat the reservation, necessary when jobs are manually re-triggered. RUBY_JOB_ALLOC: "--overlap --reservation=ci --nodes=1" @@ -25,7 +25,7 @@ variables: # Poodle # Arguments for top level allocation - POODLE_SHARED_ALLOC: "--exclusive --time=60 --nodes=1" + POODLE_SHARED_ALLOC: "--exclusive --time=70 --nodes=1" # Arguments for job level allocation POODLE_JOB_ALLOC: "--overlap --nodes=1" # Project specific variants for poodle From ae85068ba1791943bf5df4c10b1eb65103b02852 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Thu, 14 Mar 2024 22:49:28 +0100 Subject: [PATCH 22/31] Overlapping is causing to much overhead --- .gitlab/custom-jobs-and-variables.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitlab/custom-jobs-and-variables.yml b/.gitlab/custom-jobs-and-variables.yml index 39dbda4300..c4b98a911f 100644 --- a/.gitlab/custom-jobs-and-variables.yml +++ b/.gitlab/custom-jobs-and-variables.yml @@ -17,7 +17,7 @@ variables: RUBY_SHARED_ALLOC: "--exclusive --reservation=ci --time=40 --nodes=2" # Arguments for job level allocation # Note: We repeat the reservation, necessary when jobs are manually re-triggered. - RUBY_JOB_ALLOC: "--overlap --reservation=ci --nodes=1" + RUBY_JOB_ALLOC: "--reservation=ci --nodes=1" # Project specific variants for ruby PROJECT_RUBY_VARIANTS: "~shared +openmp +tests" # Project specific deps for ruby @@ -25,9 +25,9 @@ variables: # Poodle # Arguments for top level allocation - POODLE_SHARED_ALLOC: "--exclusive --time=70 --nodes=1" + POODLE_SHARED_ALLOC: "--exclusive --time=40 --nodes=2" # Arguments for job level allocation - POODLE_JOB_ALLOC: "--overlap --nodes=1" + POODLE_JOB_ALLOC: "--nodes=1" # Project specific variants for poodle PROJECT_POODLE_VARIANTS: "~shared +openmp +tests" # Project specific deps for poodle From 7bfa868ee12c72921598c4dc1343b9c8f8c12405 Mon Sep 17 00:00:00 2001 From: Rich Hornung Date: Thu, 14 Mar 2024 16:12:33 -0700 Subject: [PATCH 23/31] Fix syntax error in script --- scripts/lc-builds/corona_sycl.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/lc-builds/corona_sycl.sh b/scripts/lc-builds/corona_sycl.sh index f5fdf02adb..20e8f918af 100755 --- a/scripts/lc-builds/corona_sycl.sh +++ b/scripts/lc-builds/corona_sycl.sh @@ -68,10 +68,10 @@ echo echo " 1) Load the ROCm module version matching the version in the compiler path" echo " you passed to this script." echo -echo " 2) Set the "LD_LIBRARY_PATH environment variable to " -echo " ${SYCL_PATH}/lib:${SYCL_PATH}/lib64:${LD_LIBRARY_PATH}" +echo " 2) Prefix the LD_LIBRARY_PATH environment variable with " +echo " SYCL_PATH/lib:SYCL_PATH/lib64" echo echo " where SYCL_PATH is set to the compiler installation path you passed" -echo " to this script." +echo " to this script (using the proper command for your shell)." echo echo "***********************************************************************" From ee832c8090d72f13fff81fac643238eb2dba5ab3 Mon Sep 17 00:00:00 2001 From: "Adrien M. BERNEDE" <51493078+adrienbernede@users.noreply.github.com> Date: Sat, 16 Mar 2024 08:00:27 +0100 Subject: [PATCH 24/31] Fix: impossible to get 2 nodes on poodle --- .gitlab/custom-jobs-and-variables.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/custom-jobs-and-variables.yml b/.gitlab/custom-jobs-and-variables.yml index c4b98a911f..eb7011b78a 100644 --- a/.gitlab/custom-jobs-and-variables.yml +++ b/.gitlab/custom-jobs-and-variables.yml @@ -25,7 +25,7 @@ variables: # Poodle # Arguments for top level allocation - POODLE_SHARED_ALLOC: "--exclusive --time=40 --nodes=2" + POODLE_SHARED_ALLOC: "--exclusive --time=60 --nodes=1" # Arguments for job level allocation POODLE_JOB_ALLOC: "--nodes=1" # Project specific variants for poodle From 94e7f68ff7e4e55093efa6db276bceb7447e6cf6 Mon Sep 17 00:00:00 2001 From: Robert Chen Date: Fri, 29 Mar 2024 13:47:14 -0700 Subject: [PATCH 25/31] Update SYCL shared memory accessor. --- include/RAJA/policy/sycl/launch.hpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/include/RAJA/policy/sycl/launch.hpp b/include/RAJA/policy/sycl/launch.hpp index e9e9d8390d..0dffee6a21 100644 --- a/include/RAJA/policy/sycl/launch.hpp +++ b/include/RAJA/policy/sycl/launch.hpp @@ -73,8 +73,7 @@ struct LaunchExecute> { q->submit([&](cl::sycl::handler& h) { - auto s_vec = cl::sycl::accessor (params.shared_mem_size, h); + auto s_vec = ::sycl::local_accessor (params.shared_mem_size, h); h.parallel_for (cl::sycl::nd_range<3>(gridSize, blockSize), @@ -84,7 +83,7 @@ struct LaunchExecute> { ctx.itm = &itm; //Point to shared memory - ctx.shared_mem_ptr = s_vec.get_pointer().get(); + ctx.shared_mem_ptr = s_vec.get_multi_ptr<::sycl::access::decorated::yes>().get(); body_in(ctx); @@ -165,8 +164,7 @@ struct LaunchExecute> { q->submit([&](cl::sycl::handler& h) { - auto s_vec = cl::sycl::accessor (params.shared_mem_size, h); + auto s_vec = ::sycl::local_accessor (params.shared_mem_size, h); h.parallel_for (cl::sycl::nd_range<3>(gridSize, blockSize), @@ -176,7 +174,7 @@ struct LaunchExecute> { ctx.itm = &itm; //Point to shared memory - ctx.shared_mem_ptr = s_vec.get_pointer().get(); + ctx.shared_mem_ptr = s_vec.get_multi_ptr<::sycl::access::decorated::yes>().get(); (*lbody)(ctx); From e39d5d2a63c6962b8aabe5b2fcc6966ecb3b217b Mon Sep 17 00:00:00 2001 From: Robert Chen Date: Fri, 29 Mar 2024 14:43:28 -0700 Subject: [PATCH 26/31] Update to BLT v0.6.2. --- blt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blt b/blt index 058b312f8a..9ff77344f0 160000 --- a/blt +++ b/blt @@ -1 +1 @@ -Subproject commit 058b312f8a5ef305e12a4380deaa13d618eff54e +Subproject commit 9ff77344f0b2a6ee345e452bddd6bfd46cbbfa35 From 6f343e74a7c0e404d48b59edea25b5dba12847ac Mon Sep 17 00:00:00 2001 From: Robert Chen Date: Fri, 29 Mar 2024 15:52:06 -0700 Subject: [PATCH 27/31] Use newly built SYCL compiler. --- scripts/lc-builds/corona_sycl.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/lc-builds/corona_sycl.sh b/scripts/lc-builds/corona_sycl.sh index 20e8f918af..36c094e4ab 100755 --- a/scripts/lc-builds/corona_sycl.sh +++ b/scripts/lc-builds/corona_sycl.sh @@ -13,7 +13,7 @@ if [[ $# -lt 1 ]]; then echo " 1) SYCL compiler installation path" echo echo "For example: " - echo " corona_sycl.sh /usr/workspace/raja-dev/clang_sycl_a0117ab8692a_hip_gcc10.2.1_rocm5.6.0" + echo " corona_sycl.sh /usr/workspace/raja-dev/clang_sycl_2f03ef85fee5_hip_gcc10.3.1_rocm5.7.1" exit fi From 65b7504525a7c3d4b69d2f46be598b8fd30becbc Mon Sep 17 00:00:00 2001 From: Rich Hornung Date: Tue, 2 Apr 2024 13:35:20 -0700 Subject: [PATCH 28/31] Update camp submodule to v2024.02.1 release --- tpl/camp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tpl/camp b/tpl/camp index 03c80a6c6a..79c320fa09 160000 --- a/tpl/camp +++ b/tpl/camp @@ -1 +1 @@ -Subproject commit 03c80a6c6ab4f97e76a52639563daec71435a277 +Subproject commit 79c320fa09db987923b56884afdc9f82f4b70fc4 From fe4250e197544b1c3069c4630da496ced973c0a2 Mon Sep 17 00:00:00 2001 From: Rich Hornung Date: Tue, 2 Apr 2024 14:08:58 -0700 Subject: [PATCH 29/31] Update version number --- CMakeLists.txt | 2 +- docs/conf.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index e27ced7557..1e4823564b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -16,7 +16,7 @@ include(CMakeDependentOption) # Set version number set(RAJA_VERSION_MAJOR 2024) set(RAJA_VERSION_MINOR 02) -set(RAJA_VERSION_PATCHLEVEL 0) +set(RAJA_VERSION_PATCHLEVEL 1) if (RAJA_LOADED AND (NOT RAJA_LOADED STREQUAL "${RAJA_VERSION_MAJOR}.${RAJA_VERSION_MINOR}.${RAJA_VERSION_PATCHLEVEL}")) message(FATAL_ERROR "You are mixing RAJA versions. Loaded is ${RAJA_LOADED}, expected ${RAJA_VERSION_MAJOR}.${RAJA_VERSION_MINOR}.${RAJA_VERSION_PATCHLEVEL}") diff --git a/docs/conf.py b/docs/conf.py index c523ce8c26..1570ed2888 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -88,7 +88,7 @@ # The short X.Y version. version = u'2024.02' # The full version, including alpha/beta/rc tags. -release = u'2024.02.0' +release = u'2024.02.1' # The language for content autogenerated by Sphinx. Refer to documentation # for a list of supported languages. From b21c8c42be2fa6381b3ff8cbf85033dadbc8b280 Mon Sep 17 00:00:00 2001 From: Rich Hornung Date: Tue, 2 Apr 2024 14:09:18 -0700 Subject: [PATCH 30/31] Fill in release notes --- RELEASE_NOTES.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 06b703b3b7..2e26861191 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -20,6 +20,25 @@ Notable changes include: * Bug fixes/improvements: +Version 2024.02.1 -- Release date 2024-04-03 +============================================ + +This release contains submodule updates and minor RAJA improvements. + +Notable changes include: + + * New features / API changes: + * NONE. + + * Build changes/improvements: + * Update BLT submodule to v0.6.2 release. + * Update camp submodule to v2024.02.1 release. + + * Bug fixes/improvements: + * Various changes to quiet compiler warnings in SYCL builds related + to deprecated usage. + + Version 2024.02.0 -- Release date 2024-02-14 ============================================ From e1c48a1bcae17d3b3a9afe01bd059e7d06c15987 Mon Sep 17 00:00:00 2001 From: Rich Hornung Date: Wed, 3 Apr 2024 08:07:59 -0700 Subject: [PATCH 31/31] Don't run SYCL tests. No GPU available. --- Dockerfile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index 769de328e6..89e6a83f70 100644 --- a/Dockerfile +++ b/Dockerfile @@ -114,6 +114,5 @@ COPY . /home/raja/workspace WORKDIR /home/raja/workspace/build RUN /bin/bash -c "source /opt/view/setvars.sh && \ cmake -DCMAKE_CXX_COMPILER=dpcpp -DRAJA_ENABLE_SYCL=On -DENABLE_OPENMP=Off -DENABLE_ALL_WARNINGS=Off -DBLT_CXX_STD=c++17 .. && \ - make -j 6 &&\ - ctest -T test --output-on-failure" && \ + make -j 6" && \ cd .. && rm -rf build