Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide GOTCHA version in header #149

Closed
bertwesarg opened this issue Apr 25, 2024 · 3 comments · Fixed by #150
Closed

Please provide GOTCHA version in header #149

bertwesarg opened this issue Apr 25, 2024 · 3 comments · Fixed by #150
Assignees

Comments

@bertwesarg
Copy link
Contributor

The source version, not the library interface version (aka libtool version). Thanks.

@hariharan-devarajan hariharan-devarajan self-assigned this Apr 29, 2024
@hariharan-devarajan
Copy link
Member

Do u mean macro definitions for Major Minor and revision of source?

Something like

#define GOTCHA_MAJOR_VERSION 1

and so on?

If so sure, i can generate it for the installation.

@bertwesarg
Copy link
Contributor Author

exactly. To integrate #148 into our build system, I need to check the version. For versions <=1.0.6 I will keep libOpenCL.so in our filter list.

@hariharan-devarajan
Copy link
Member

@bertwesarg Ok, I added a PR for this #150.

docs show how to use them.

This uses boost style version checking so that u can do something like this

#if GOTCHA_VERSION >= GOTCHA_GET_VERSION(1,0,6)
...
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants