Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it make sense to use it with reacstrap? #198

Open
hanoii opened this issue Jan 15, 2019 · 5 comments
Open

Does it make sense to use it with reacstrap? #198

hanoii opened this issue Jan 15, 2019 · 5 comments

Comments

@hanoii
Copy link

hanoii commented Jan 15, 2019

Is it OK to use both libraries or one would conflict with the other? reactrap needs the bootstrap css to work, which I take brings in fonts and stylings anyway.

@fullofcaffeine
Copy link

+1 I'm trying to use it with boostrap. For the most part, it works, but I have to do a lot of style hacking in order to prevent boostrap from overriding the styles from typography.js. See: gatsbyjs/gatsby@5caf95e#r37034290.

@fullofcaffeine
Copy link

fullofcaffeine commented Feb 5, 2020

Hi, could any of the core members chime in to give some insights regarding this issue?

I'm currently using Bootstrap 4 + Typopgrahy.js (after going through a somewhat long process solve a related issue ) and while it works, there are clearly some small issues, mainly related to Bootstrap overwritting Typography.js rules or vice-versa. At the moment, I'm deliberately loading Typography.js after Bootstrap so that the fonts are actually set.

I think the main rationale for using both is twofold:

  1. Bootstrap is popular and well-known, it's a really productive framework after you get the hang of it (my case)

  2. Typography.js is really nice typeface-wise and the rules and themes save up a lot of time. Doing the same manually on Bootstrap (choosing fonts, overwriting typeface rules etc) would be very tedious.

So I think there's a huge potential here of using both together, but there's no mention of it anywhere in the docs :(

@fullofcaffeine
Copy link

fullofcaffeine commented Feb 6, 2020

This issue has been open for more than an year. I'm not expecting immediate answers from open-source maintainers - I'm one myself and I know how it is - but it's a long time for not having a reply. Is this project still being maintained or is this even the right forum for questions?

@vincentreynaud
Copy link

vincentreynaud commented Jan 19, 2022

@fullofcaffeine agreed! I am struggling to find the right setup to avoid bootstrap overwriting typography.js. the issue is still there to this day.

@fullofcaffeine
Copy link

@vincentreynaud Yeah, that's unfortunate. I managed to find a workaround but it was an ugly one. I don't recall exactly what it was now, but I'll try to refresh my memory soon and document here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants