Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent releases missing files/ folder in npm package #208

Open
jacobq opened this issue Oct 16, 2020 · 2 comments
Open

Recent releases missing files/ folder in npm package #208

jacobq opened this issue Oct 16, 2020 · 2 comments

Comments

@jacobq
Copy link

jacobq commented Oct 16, 2020

Recently I updated my typeface-league-spartan package from v0.0.44 to v1.1.13 and found that this broke my application (font no longer loaded). A quick peek at the package tarballs from npm shows that 1.1.8 thru latest (1.1.13) do not contain the files/ folder, which is where the actual font assets are. I have no idea why this font wasn't part of the many other versions between here, and I suppose I shouldn't expect a v0.x package not to break when updating across a 3 years span, but still....

@jacobq jacobq changed the title Recent releases missing files/ folder in package Recent releases missing files/ folder in npm package Oct 16, 2020
@jacobq
Copy link
Author

jacobq commented Oct 16, 2020

Repro:

  1. Fetch https://registry.npmjs.org/typeface-league-spartan/-/typeface-league-spartan-0.0.44.tgz
  2. Observe presence of files/ folder in archive:
$ tar ztf typeface-league-spartan-0.0.44.tgz
package/package.json
package/.npmignore
package/README.md
package/SIL Open Font License.txt
package/files/.npmignore
package/files/league-spartan-700.eot
package/files/league-spartan-700.svg
package/files/league-spartan-700.ttf
package/files/league-spartan-700.woff
package/files/league-spartan-700.woff2
package/files-hash.json
package/index.css
  1. Fetch https://registry.npmjs.org/typeface-league-spartan/-/typeface-league-spartan-1.1.13.tgz
  2. Observe that the files/ folder is missing:
$ tar ztf typeface-league-spartan-1.1.13.tgz
package/index.css
package/files-hash.json
package/package.json
package/README.md
package/SIL Open Font License.txt

@jacobq
Copy link
Author

jacobq commented Oct 16, 2020

Also, same thing for typeface-cooper-hewitt -- does it have something to do with these fonts not being part of Google Fonts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant