New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NodeBundle] URLHelper generate url for deleted node #3309

Open

dannyvw opened this issue Sep 13, 2023 · 0 comments

Contributor

dannyvw commented Sep 13, 2023 •

edited

The URLHelper generate a url for a deleted node because this query (https://github.com/Kunstmaan/KunstmaanBundlesCMS/blob/6.x/src/Kunstmaan/NodeBundle/Helper/URLHelper.php#L129) does not check if the node was deleted. The url leads to an 404 page.

Also fetchAssociative (https://github.com/Kunstmaan/KunstmaanBundlesCMS/blob/6.x/src/Kunstmaan/NodeBundle/Helper/URLHelper.php#L133) can return false which is not accepted by the return type (https://github.com/Kunstmaan/KunstmaanBundlesCMS/blob/6.x/src/Kunstmaan/NodeBundle/Helper/URLHelper.php#L123).

Spotted during cleanup of nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment