Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kunstmaan/google-api-custom with official google package #2780

Open
acrobat opened this issue Oct 7, 2020 · 3 comments
Open

Replace kunstmaan/google-api-custom with official google package #2780

acrobat opened this issue Oct 7, 2020 · 3 comments

Comments

@acrobat
Copy link
Member

acrobat commented Oct 7, 2020

Currently we're using a custom fork of the google api php client, but this package is lagging behind on the official package and users can't install the google package next to it because of conflicting namespaces. Try to remove the kunstmaan/google-api-custom package and depend on the google/apiclient package instead.

@tarjei
Copy link
Contributor

tarjei commented Jan 30, 2021

Hi, I would just like to vote for this issue!Any ideas on what is needed to be done?

@acrobat
Copy link
Member Author

acrobat commented Feb 1, 2021

A few thing are needed here:

  • Replace kunstmaan/google-api-custom package with google/apiclient and see what the incompatibilities are.
    • Check which bc breaks there are and if we can change the code in a way to support both libs but deprecate the old one.
  • Most of the implementation changes will need to change in the dashboard bundle (the google analytics widget)

So as a first step we need to get an overview of places in the code that need changes and if we can do these changes without breaking BC

@acrobat
Copy link
Member Author

acrobat commented Feb 9, 2023

Related to #3245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants