Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Community Links #10

Merged
merged 4 commits into from
Apr 14, 2022
Merged

Updated Community Links #10

merged 4 commits into from
Apr 14, 2022

Conversation

Tomiiwa
Copy link

@Tomiiwa Tomiiwa commented Apr 8, 2022

Fixes #8

Updated all the links on the ReadMe doc. However, I could not find the links Services Repo Components. I can add it if it can be provided.

@MoralCode
Copy link
Member

Thanks for making this contribution!

Could you share some examples of the links you werent able to find replacements for? I'm not quite sure which links you are referring to

@Tomiiwa
Copy link
Author

Tomiiwa commented Apr 8, 2022

These are under the Repo Components Section:
Kubos Core Services - https://docs.kubos.com/1.21.0/os-docs/services/core-services.html
Hardware Services - https://docs.kubos.com/1.21.0/os-docs/services/hardware-services.html

@MoralCode
Copy link
Member

ah, it seems like those links are meant to point to other docs pages that got moved since those links were made.

My guess would be that theyre supposed to point to https://docs.kubos.com/1.21.0/ecosystem/services/core-services.html and https://docs.kubos.com/1.21.0/ecosystem/services/hardware-services.html.

@Tomiiwa
Copy link
Author

Tomiiwa commented Apr 9, 2022

alright, got it

MoralCode
MoralCode requested changes Apr 9, 2022
View reviewed changes
Copy link
Member

@MoralCode MoralCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great start overall, thanks again for making these changes!

I added some comments regarding a couple minor tweaks to what you have done so far, but overall it looks like a good first pass

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Tomiiwa
Copy link
Author

Tomiiwa commented Apr 10, 2022

alright, i will check out those comments

@MoralCode MoralCode merged commit 949597c into KubOS-Preservation-Group:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoralCode MoralCode MoralCode requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update community links
2 participants
@Tomiiwa @MoralCode