Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this repository active? #261

Open
lolgear opened this issue Nov 9, 2015 · 14 comments
Open

is this repository active? #261

lolgear opened this issue Nov 9, 2015 · 14 comments

Comments

@lolgear
Copy link

lolgear commented Nov 9, 2015

is this repository active? last commit was 3 months ago

@KrauseFx
Copy link
Owner

This repo is not active

@mRs-
Copy link
Collaborator

mRs- commented Nov 20, 2015

@KrauseFx maybe we should search a new repo master for this. Unfortunately I don't have the time for this right now :(

@KrauseFx
Copy link
Owner

I did search for a long time, but nobody wanted to take over. Let me know if you find someone.

@isadon
Copy link
Collaborator

isadon commented Dec 9, 2015

Hey @KrauseFx can I take over the repo? Well.. to be more clear I kind of already forked the library and created a pod for my own version of this Library. Please see here --> https://github.com/donileo/RMessage. I took about two days doing the following:
Refactoring the code to be more clean
Doing various bug fixes on the library such as the notifications not centering properly when a navigation controller was shown
Removing the bad blur code as well as adding more customization keys such as opacity and separating title and subtitle shadows.
Uses Autolayout

Hope renaming the library and making the above changes isn't bad with you and I do plan on noting in my Readme that the code is originally based on TSMessages though I did change various things around.

@mRs-
Copy link
Collaborator

mRs- commented Dec 9, 2015

Took a first look, seems fine to me. Do you have a full history of your changes?

@isadon
Copy link
Collaborator

isadon commented Dec 9, 2015

Im going to have cook one up for you guys. I initialized a new git history for my project since I wanted to kinda start from new so its not a perfect/true fork in the sense.

@wdcurry
Copy link

wdcurry commented Dec 9, 2015

Given the nature of github et al, it would make sense to give credit to this git on main page of RMessage.

@isadon
Copy link
Collaborator

isadon commented Dec 9, 2015

@wdcurry thats perfectly fine with me.. Just havent gotten around to updating the Readme too much :), been busy updating and refactoring a bunch of other stuff in the library.

@isadon
Copy link
Collaborator

isadon commented Dec 10, 2015

Readme updated guys.

@felipeplets
Copy link

Thanks @donileo for taking it over, I just update and it was an easy task.

@KrauseFx I recommend you to update the repo README pointing out to RMessage as an uptodate option to TSMessages.

@isadon
Copy link
Collaborator

isadon commented Feb 3, 2017

@mrs @KrauseFx I think you guys wanted a diff between RMessage and TSMessage. Feel free to do a git diff across TSMessages and RMessage.

@KrauseFx
Copy link
Owner

KrauseFx commented Feb 3, 2017

Hey @lolgear, sorry I completely missed this. I have notifications turned off for most GitHub repos. I'd be more than happy to hand you over the TSMessages main repo itself. It's used by more than 10,000 apps via CocoaPods: https://cocoapods.org/pods/TSMessages

I'll grant you commit access, and we can move the repo into its own org if you'd like 👍

One key requirement is to not break any existing setups, it should stay backwards compatible.

@isadon
Copy link
Collaborator

isadon commented Feb 3, 2017

@KrauseFx Thanks. Yea, definitely, maintaining backwards compatibility is definitely of great importance. Currently, the only feature RMessage doesn't have is the ability to use a UIButton as the notification view/image in the message itself, though that will be included shortly in the future. Considering I'm sure many people are using TSMessages without issue (or many issues :)) I'm thinking the correct thing is to get people to transition to RMessage as they see fit by putting it in the README of this repo. Thoughts? As far as moving this repo into its own org (I'm assuming you mean organization) what org would that be?

@lolgear
Copy link
Author

lolgear commented Apr 11, 2017

@KrauseFx yes, sure! Could you add me to this repository as maintainer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants