Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSMessage showNotificationInViewController: (full signature) does not use defaultViewController #254

Open
johnnypayso opened this issue Oct 8, 2015 · 0 comments

Comments

@johnnypayso
Copy link

The various "showNotificationInViewController:" methods call the full-signature method, which does not use the "defaultViewController" if a view controller is not passed in (i.e., nil). (Only the basic "showNotificationWithTitle:" methods explicitly pass in the default.)

Possible Fix:

In full-signature "showNotificationInViewController:" method:

TSMessageView *v = [[TSMessageView alloc] initWithTitle:title
...
inViewController:(viewController ?: [self defaultViewController])
...
];

Workaround:

Call method by passing in available default method:

[TSMessage showNotificationInViewController:[TSMessage defaultViewController]
...
];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant