Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] All caps headings #12

Open
kunzaatko opened this issue Nov 26, 2021 · 4 comments
Open

[feature request] All caps headings #12

kunzaatko opened this issue Nov 26, 2021 · 4 comments

Comments

@kunzaatko
Copy link

First of all, thanks for the project! It is super cool!
I think all-caps would be a great filter for some headings. Lots of books use all-caps for subheadings.

@kunzaatko
Copy link
Author

kunzaatko commented Dec 2, 2021

@Krasjet I made an attempt, at implementing a full pattern match filter. Details are in the commit message. Can you give me some feedback and tell me whether I am going in the right direction?

@kunzaatko
Copy link
Author

kunzaatko commented Dec 2, 2021

TODO:

Filter class:

  • Fix the tail problem with matching against the whole pattern and accepting only the first full match
  • When we arrive at the end without a match, we should filter the previously accepted spns.

Spec generation:

  • Add a field with a pattern to the spec.toml generation in pdfxmeta

Add tests:

  • Test whether this could be used as the other filters as the 'main' filter and not just a 'checker'

Add documentation:

  • in README.md
  • in --help

@Krasjet
Copy link
Owner

Krasjet commented Dec 6, 2021

I'll review this some time after next Thursday. Sorry for the delay.

@kunzaatko
Copy link
Author

Offcourse 👍. Take your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants