Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Error handling of location off error during turning on True North #49

Open
inson1 opened this issue Oct 16, 2023 · 1 comment
Open
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@inson1
Copy link
Contributor

inson1 commented Oct 16, 2023

If I start the True North without the location on it gives me error. Its one of the most occurred errors, that's why I think it can have its own error handling. And not just pop up with default message.

And maybe it would be even better to find out if the location is on/off and then try starting the True North.

Screenshot_2023-10-16-06-33-26-115_com.bobek.compass.jpg

Cant you do what Google maps do and ask user and if user agree then turn on the location for him?

Or just do the error pop up nicer. Something like this:

No title

For True North to work correctly, it needs your location. May you turn it on?

@Kr0oked Kr0oked added the enhancement New feature or request label Oct 21, 2023
@Kr0oked
Copy link
Owner

Kr0oked commented Oct 25, 2023

As a quick improvement I introduced a new error code 'LOCATION_DISABLED' to have something more specific eb79239. A proper message would be better, but that would basically mean a rework of the error handling functionality.

@Kr0oked Kr0oked added the wontfix This will not be worked on label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants