Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't save Wayback Machine links via bookmarklet #717

Open
respencer opened this issue Oct 25, 2023 · 2 comments
Open

Can't save Wayback Machine links via bookmarklet #717

respencer opened this issue Oct 25, 2023 · 2 comments
Labels
Bug Something isn't working Won't fix This will not be worked on

Comments

@respencer
Copy link

Bug Description

When trying to save a webpage in the Wayback Machine using the bookmarklet you get directed to the non-existent archived link of your own bookmarklet/add link.

How to reproduce

  1. Go to: https://web.archive.org/web/20230319211922/https://12factor.net/dependencies
  2. Click on your LinkAce bookmarklet.
  3. You'll now be directed to: https://web.archive.org/web/20230319211922/https://example.com/bookmarklet/add?u=https%3A%2F%2Fweb.archive.org%2Fweb%2F20230319211922%2Fhttps%3A%2F%2F12factor.net%2Fdependencies&t=The%20Twelve-Factor%20App&d=

Expected behavior

My own site link was used: https://example.com/bookmarklet/add?u=https%3A%2F%2Fweb.archive.org%2Fweb%2F20230319211922%2Fhttps%3A%2F%2F12factor.net%2Fdependencies&t=The%20Twelve-Factor%20App&d=

Logs

No response

Screenshots

No response

LinkAce version

v1.12.2

Setup Method

PHP

Operating System

Linux (Ubuntu, CentOS,...)

Client details

  • OS: IDMS Linux [like Arch Linux]
  • Browser: Mozilla Firefox
  • Browser Version: 116.0.3 (64-bit)
@respencer respencer added the Bug Something isn't working label Oct 25, 2023
@Kovah
Copy link
Owner

Kovah commented Oct 25, 2023

That's a really odd behaviour. I guess that the Wayback Machine messes with the standard window.open() function and alters how it works. Will have a deeper look later on.

@Kovah
Copy link
Owner

Kovah commented Oct 29, 2023

I can confirm that the Internet Archive messes with the window.open() function which is definitely not supposed to happen. It's a standard JS function and overriding it with something else is bad practise. At the moment there is no way around saving the URL directly in LinkAce.

@Kovah Kovah added the Won't fix This will not be worked on label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants