Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import: check the content before importing, maybe ask for confirmation #579

Open
piegamesde opened this issue Nov 24, 2022 · 1 comment
Open
Labels
Enhancement Any requests for improvements or new features

Comments

@piegamesde
Copy link

Bug Description

I just misclicked while trying to import bookmarks, and thus imported a standard HTML file. It took a long time, and obviously gave very weird results, and also took a lot of time afterwards.

How to reproduce

  1. Save some website to html file
  2. Import it
  3. Enjoy

Expected behavior

To avoid this, one could maybe check that the file to be imported a) is actually valid HTML and b) starts with <!DOCTYPE NETSCAPE-Bookmark-file-1>. Moreover, showing the number of links or maybe even a preview of the raw URLs + then asking for confirmation beforehand would be really helpful.

Logs

No response

Screenshots

No response

LinkAce version

v1.10.5

Setup Method

PHP

Operating System

Linux (Ubuntu, CentOS,...)

Client details

Arch Linux, Chromium

@piegamesde piegamesde added the Bug Something isn't working label Nov 24, 2022
@Kovah
Copy link
Owner

Kovah commented Nov 24, 2022

@Kovah Kovah added Enhancement Any requests for improvements or new features and removed Bug Something isn't working labels Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Any requests for improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants