Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Docker image for LinkAce v2 #502

Open
3 of 5 tasks
Kovah opened this issue Jul 4, 2022 · 1 comment · May be fixed by #604
Open
3 of 5 tasks

New Docker image for LinkAce v2 #502

Kovah opened this issue Jul 4, 2022 · 1 comment · May be fixed by #604
Labels
Enhancement Any requests for improvements or new features
Projects
Milestone

Comments

@Kovah
Copy link
Owner

Kovah commented Jul 4, 2022

Currently, there are two images available for LinkAce: one which only contains the application and needs a separate web server like nginx, and one that is able to run on its own as it contains said web server.

To make things easier for the users who want to set up LinkAce and me as maintainer, I want to publish only one image in the future that contains a web server. There will be only one setup process for Docker for version 2.

  • Remove the advanced image. linkace/linkace:simple becomes linkace/linkace and the previous linkace/linkace will be removed.
  • Check which web server to use in the final image, nginx and Caddy are viable options.
  • Publish the image on both the Docker Hub and the Github Container Registry.
  • Update the docs to use the www-data user when running commands inside the container.
  • Test a possible HTTPS setup with Caddy and a separate config file.

Edit:

  • I moved from nginx to Caddy. Caddy is easier to configure and manage than nginx.
  • Caddy is configured to trust all private networks as proxies, including Docker networks.
  • The release Docker image is ready to be used with SQLite without difficult configurations. Only DB_CONNECTION and DB_DATABASE are needed.
  • The base image now includes Supervisor and Caddy by default which saves a bit of build time.
  • The ownership and permissions of the files inside the image are changed to www-data to prevent permission conflicts.
@Kovah Kovah added the Enhancement Any requests for improvements or new features label Jul 4, 2022
@Kovah Kovah added this to the v2.0.0 milestone Jul 4, 2022
@Kovah Kovah added this to Backlog in Development via automation Jul 4, 2022
@ffraenz
Copy link

ffraenz commented Jul 4, 2022

I think merging the PHP and Nginx containers is a great improvement. I never was satisfied with combining the two in my own setups. Also, having less images to maintain is long term a win for everyone.

However you should keep the existing images/tags for as long as possible to not break existing installations or automated deployments.

It would be nice having a documented integration point or strategy to configure Let's Encrypt with it as that should be an important use case.

Kovah added a commit that referenced this issue Nov 17, 2022
Kovah added a commit that referenced this issue Feb 6, 2024
- Removes the advanced image version where PHP and nginx are separated
- Replaces nginx with Caddy
- The release image is now ready to be used with SQLite without many hassles
- Adjusts the build processes accordingly
- Removes unnecessary config files
@Kovah Kovah linked a pull request Feb 6, 2024 that will close this issue
@Kovah Kovah moved this from Backlog to Release Queue in Development Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Any requests for improvements or new features
Projects
Development
  
Release Queue
Development

Successfully merging a pull request may close this issue.

2 participants