Check NodeJs and D8 versions before adding --experimental-wasm-gc #213
Conversation
|
As of testing, recent d8/nodeJs versions are only supported starting from @qurbonzoda, please let me know which version you would prefer, and I'll push tests. |
| addWasmArguments() | ||
| val addGcArgs = project.extensions.findByType(NodeJsRootExtension::class.java)?.let { | ||
| val nodeVersion = VersionNumber.parse(it.nodeVersion) | ||
| // Starting from version 22, NodeJS is shipped with V8 versions |
There was a problem hiding this comment.
Do we really want to support nodejs version <22? Maybe better just to drop this code as deprecated?
There was a problem hiding this comment.
Sounds good to me. Those who really need an older version can always supply the experimental-gc flag manually (but we should document that workaround, though).
@qurbonzoda WDYT?
There was a problem hiding this comment.
I do not really think that we have so many users which run benchmarks with old node/d8. So maybe we could just drop it without any workarounds and etc?
There was a problem hiding this comment.
I'll use an older version of Node for example. I develop VS Code extensions and my Node version is always synced with the Electron one.
There was a problem hiding this comment.
@lppedd, I'm curious: does the Kotlin/Wasm work with it?
There was a problem hiding this comment.
Yes, I can execute K/WASM tests, and I can load WASM binaries inside of my extensions (e.g., inside of a webview).
See also https://code.visualstudio.com/blogs/2024/05/08/wasm for what VS Code will support going forward.
Hopefully we'll have a VS Code version based on Electron with Node 22+ by the end of the year, but who knows.
I think letting the consumer choose the version is a better path anyway.
There was a problem hiding this comment.
Given there are use cases, I would prefer to keep the --experimental-wasm-gc argument for users on older Kotlin and/or Node.js versions.
I prefer passing the Kotlin version to |
Closes #212