Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WasmJs: don't add experimental-wasm-gc flag for NodeJs >= 22 #212

Closed
fzhinkin opened this issue May 13, 2024 · 2 comments · Fixed by #213
Closed

WasmJs: don't add experimental-wasm-gc flag for NodeJs >= 22 #212

fzhinkin opened this issue May 13, 2024 · 2 comments · Fixed by #213
Labels
bug Something isn't working

Comments

@fzhinkin
Copy link
Contributor

Starting from version 22, NodeJS is shipped with the V8 that no longer accepts --experimental-wasm-gc flag:

> Task :wasmJsBenchmark FAILED
Running 'main' benchmarks for 'wasmJs'
~/.gradle/nodejs/node-v22.0.0-darwin-arm64/bin/node: bad option: --experimental-wasm-gc

kotlinx-benchmark should take V8/NodeJs version into consideration when adding Wasm options.
@fzhinkin fzhinkin added the bug Something isn't working label May 13, 2024
@fzhinkin
Copy link
Contributor Author

https://chromium-review.googlesource.com/c/v8/v8/+/5199138

It seems like the option no longer exist starting from V8 ~ 12.3.68

@fzhinkin
Copy link
Contributor Author

D8 seems to be more friendly to unknown flags: Warning: unknown flag --experimental-wasm-gc.

fzhinkin added a commit to fzhinkin/kotlinx-benchmark that referenced this issue May 13, 2024
@fzhinkin
Check NodeJs and D8 versions before adding --experimental-wasm-gc
bcda119 
Closes Kotlin#212
@fzhinkin fzhinkin mentioned this issue May 13, 2024
Merged
fzhinkin added a commit that referenced this issue May 27, 2024
@fzhinkin
Check NodeJs and D8 versions before adding --experimental-wasm-gc (#213)
aff0cac 
Starting from version 22, NodeJS is shipped with the V8 
that no longer accepts --experimental-wasm-gc flag.
The option disappeared from V8 somewhere around 12.3.68.

To avoid errors when running benchmarks with recent
NodeJS/D8 version, plugin now checks runtime's version and
appends  --experimental-wasm-gc flag only when needed.

Closes #212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check NodeJs and D8 versions before adding --experimental-wasm-gc fzhinkin/kotlinx-benchmark
1 participant
@fzhinkin