Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rust version of Krakatau #477

Open
Storyyeller opened this issue Nov 5, 2023 · 1 comment
Open

Upgrade to Rust version of Krakatau #477

Storyyeller opened this issue Nov 5, 2023 · 1 comment

Comments

@Storyyeller
Copy link

I rewrote the Krakatau assembler and disassembler in Rust, and I strongly recommend switching to the Rust version, since it is faster and has more features. Additionally, some users report having problems with the Python version when using recent versions of Python 3.

I haven't rewritten the decompiler yet, so that remains Python 2.7 only for now.

@Storyyeller Storyyeller changed the title Upgrdae to Rust version of Krakatau Upgrade to Rust version of Krakatau Nov 5, 2023
@ThexXTURBOXx
Copy link
Contributor

This is a good idea, however, it comes with a few caveats:

  • One of the main features why BCV is integrating Krakatau is that it features a decompiler. The Rust rewrite not yet featuring one is a huge dealbreaker and basically removes a major feature
  • The Python version works on every system where Python is installed whilst the Rust version would need an own build for every system/architecture. I can already see issues asking us to add a specific build for platform x using architecture y

Please correct me if I am wrong with any of my assumptions here, but I think this is how it stands for now.
When a decompiler is eventually added to Krakatau, it might be worth considering migrating to v2 (or at least adding an option to BCV to enable it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants