Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for non-labeled Secrets (Plugins' config, credentials) #5876

Open
2 of 6 tasks
czeslavo opened this issue Apr 17, 2024 · 0 comments
Open
2 of 6 tasks

Drop support for non-labeled Secrets (Plugins' config, credentials) #5876

czeslavo opened this issue Apr 17, 2024 · 0 comments
Labels
area/perf Performance Related Issues
Milestone

Comments

@czeslavo
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

In KIC 3.2 we made labeling Secrets (Plugin config and credentials) obligatory from the standpoint of the default ValidatingWebhookConfiguration we provide - meaning that Secrets that are not labeled with our custom labels (konghq.com/validate and konghq.com/credential) are not going to be validated by the validating webhook (#5856). We still didn't make the labels obligatory to make them visible by KIC's reconcile loops as we cache Secrets with no filters.

This issue is the next step in making the labels required - this time not only for the validation but also for making them be cached and reconciled by KIC. That will allow avoiding issues where KIC fails to boot because of cache sync timeouts in environments with a high volume of Secrets that are not meant to be reconciled by KIC.

Proposed Solution

Additional information

No response

Acceptance Criteria

  • KIC no longer caches Secrets that do not have our custom labels (konghq.com/credentials, konghq.com/validate)
  • Validation webhook only verifies Secrets that have our custom labels
  • A breaking change note with a migration path described is added to the changelog
  • All docs.konghq.com articles where Secrets are created are updated accordingly to be always labeled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/perf Performance Related Issues
Projects
None yet
Development

No branches or pull requests

1 participant