fix: wildcard pattern matching #7265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
hvitoi
force-pushed
the
fix-wildcard-pattern-match
branch
from
51716f7
to
9729f86
Compare
|
Thanks for the contribution. @filfreire can you review it? |
filfreire
force-pushed
the
fix-wildcard-pattern-match
branch
from
9729f86
to
4c3fdf1
Compare
|
What are the next steps on this? @filfreire Is there any action left? |
filfreire
approved these changes
Apr 17, 2024
filfreire
force-pushed
the
fix-wildcard-pattern-match
branch
from
4c3fdf1
to
fcf4043
Compare
|
@jackkav @gatzjames @CurryYangxx if possible please give a second pass to this |
|
Nice catch, can confirm. I suspect the tests pass because they run in a node context so web apis are polyfilled with node ones. 
|
jackkav
approved these changes
Apr 19, 2024
jackkav
force-pushed
the
fix-wildcard-pattern-match
branch
2 times, most recently
from
0306a61
to
d1cf1b0
Compare
jackkav
force-pushed
the
fix-wildcard-pattern-match
branch
from
d1cf1b0
to
6896471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7181
Rationale
The
new URLkeyword was previously instantiating an unknown class which does encode the hostname characters so thathttps://*.myhost.com/was turned intohttps://%2A.myhost.comand the latter would not match with the actual url being requested and thus the certificate would not be attached to the request itself.This fix forces the use of the node:url module which does return a more predictable output (and not encoding the star symbol).
It's not clear why this bug is not caught by the test suite since this exact test case is already validated. If you have any suggestion we could explore other test scenarios.