Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: wildcard values don't work for the host of certificates #7181

Closed
1 task done
alice-wondered opened this issue Mar 14, 2024 · 3 comments · Fixed by #7265
Closed
1 task done

Regression: wildcard values don't work for the host of certificates #7181

alice-wondered opened this issue Mar 14, 2024 · 3 comments · Fixed by #7265
Labels
B-bug Bug: general classification S-unverified Status: Unverified by maintainer

Comments

@alice-wondered
Copy link

alice-wondered commented Mar 14, 2024

Expected Behavior

Wildcard values such as *.mydomain.com should work for host matching certificates for mTLS

Actual Behavior

Wildcard values don't match properly and each subdomain must be added individually.

Seems to be a regression of #243

Reproduction Steps

No response

Is there an existing issue for this?

Additional Information

No response

Insomnia Version

8.6.1

What operating system are you using?

macOS

Operating System Version

Sonoma 14.4

Installation method

insomnia.rest

Last Known Working Insomnia version

No response

@alice-wondered alice-wondered added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels Mar 14, 2024
@hvitoi
Copy link
Contributor

hvitoi commented Mar 31, 2024

This regression may have been introduced by #6274. Test cases that validate the wildcard matching have been removed.

@hvitoi
Copy link
Contributor

hvitoi commented Mar 31, 2024

There is no much context on the PR description of why this feature has been removed as part of the electron bump

@hvitoi
Copy link
Contributor

hvitoi commented Apr 12, 2024

I'm debugging this issue and this regression is being cause by this line.
On building an URL object it is additionally encoding the hostname characters so that https://*.myhost.com/ is turned into https://%2A.myhost.com and the latter won't match with the actual url being requested and thus won't attach the certificate into the request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification S-unverified Status: Unverified by maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants