feat: TLS listeners supported #112
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
mlavacca
force-pushed
the
mlavacca/tls-listeners
branch
from
aef7eb8
to
e6752fc
Compare
pmalek
reviewed
May 8, 2024
Comment on lines
+36
to
+40
| // ListenereReasonInvalidTLSMode must be used with the Accepted condition | ||
| // to express that the listener has an invalid TLS mode. | ||
| // HTTPS can only be configured with mode Terminate, while TLS can only be | ||
| // be configured with mode Passthrough. | ||
| ListenereReasonInvalidTLSMode k8sutils.ConditionReason = "InvalidTLSMode" |
There was a problem hiding this comment.
Suggested change
| // ListenereReasonInvalidTLSMode must be used with the Accepted condition | |
| // to express that the listener has an invalid TLS mode. | |
| // HTTPS can only be configured with mode Terminate, while TLS can only be | |
| // be configured with mode Passthrough. | |
| ListenereReasonInvalidTLSMode k8sutils.ConditionReason = "InvalidTLSMode" | |
| // ListenerReasonInvalidTLSMode must be used with the Accepted condition | |
| // to express that the listener has an invalid TLS mode. | |
| // HTTPS can only be configured with mode Terminate, while TLS can only be | |
| // be configured with mode Passthrough. | |
| ListenerReasonInvalidTLSMode k8sutils.ConditionReason = "InvalidTLSMode" |
We might add a reference link to https://gateway-api.sigs.k8s.io/guides/tls/#clientserver-and-tls which contains the table with allowed modes for particular route types.
Comment on lines
+437
to
+440
| { | ||
| Name: "", | ||
| Value: consts.ControlPlaneAdmissionWebhookEnvVarValue, | ||
| }, |
There was a problem hiding this comment.
I believe we don't need this right?
Comment on lines
+593
to
+595
| if listener.Protocol != gatewayv1.HTTPProtocolType && | ||
| listener.Protocol != gatewayv1.HTTPSProtocolType && | ||
| listener.Protocol != gatewayv1.TLSProtocolType { |
There was a problem hiding this comment.
Can we use the supportedRoutesByProtocol() like so:
_, ok := supportedRoutesByProtocol()[listener.Protocol]
and then check !ok? This way we can avoid forgetting to update this when we add support for other protocols. WDYT?
Comment on lines
+599
to
+611
| // Only TLS terminate mode supported with HTTPS Listeners. | ||
| if listener.Protocol == gatewayv1.HTTPSProtocolType && *listener.TLS.Mode != gatewayv1.TLSModeTerminate { | ||
| acceptedCondition.Status = metav1.ConditionFalse | ||
| acceptedCondition.Reason = string(ListenereReasonInvalidTLSMode) | ||
| acceptedCondition.Message = "Only Terminate mode is supported with HTTPS listeners" | ||
| } | ||
|
|
||
| // Only TLS passthrough mode supported with TLS Listeners. | ||
| if listener.Protocol == gatewayv1.TLSProtocolType && *listener.TLS.Mode != gatewayv1.TLSModePassthrough { | ||
| acceptedCondition.Status = metav1.ConditionFalse | ||
| acceptedCondition.Reason = string(ListenereReasonInvalidTLSMode) | ||
| acceptedCondition.Message = "Only Passthrough mode is supported with TLS listeners" | ||
| } |
There was a problem hiding this comment.
WDYT about using a switch on the protocol here and then nesting the particular conditions for those protocols inside the cases?
There was a problem hiding this comment.
Can we add one more sample with just the TLSRoute and a Gateway with TLS listener?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support for TLS Listeners and TLSRoutes.
Which issue this PR fixes
Fixes #64
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes