Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to override container name or to add prefix #922

Open
bharathiram opened this issue Nov 1, 2023 · 2 comments
Open

Option to override container name or to add prefix #922

bharathiram opened this issue Nov 1, 2023 · 2 comments
Assignees

Comments

@bharathiram
Copy link

bharathiram commented Nov 1, 2023

Chart update request: Need the ability to override the container name with a value from values file

proxy as a container name is too generic which is causing issues in autodiscovery with our monitoring tools. We would like to name it as kong-proxy to differentiate it from other proxies.

https://github.com/Kong/charts/blob/main/charts/kong/templates/deployment.yaml#L129

@rainest
Copy link
Contributor

rainest commented Nov 15, 2023

What is the autodiscovery tool in question and what is its behavior?

In general I don't think container names should be a concern, since they're internal to a Pod and not really designed for consumption by other tools. The Pods do have more descriptive labels.

@rainest rainest self-assigned this Nov 16, 2023
@rainest
Copy link
Contributor

rainest commented Nov 20, 2023

With which tool? Is it not able to group containers by Pod or add Pod metadata to them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants