Split the Deployment #923
Closed
Split the Deployment #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helm is being mean and not honoring comment tags. Why? No idea. Not
bothering to figure it out and instead just dumping WIP stuff that can't
render in a jail directory so that Helm stops complaining about
misplaced "{{- end -}}" things it shouldn't be trying to render.
4 tasks
Sorta deploy Kong using the Deployment helper. Missing several things. Selectors are broken as heck and don't work. Need to split that for separate Deployments better.
4 tasks
|
Was this superseded by #947 ? |
|
Archived in my fork: https://github.com/rainest/charts-citest/tree/split-kong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Splits the Deployment into separate proxy and controller Deployments. Adds settings to configure the Deployments settings separately where settings previously configured the one unified Deployment. Rearranges some settings.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Currently this is just a bunch of TODOs explaining the tasks needed to handle this, for easier understanding of what the end result would look like.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.