Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.kubernetes.io/version Pod label always points to .Chart.AppVersion regardless whats set in values #903

Open
pmalek opened this issue Oct 17, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@pmalek
Copy link
Member

pmalek commented Oct 17, 2023

Problem statement

kong chart's Pods are deployed with a set of labels, among those there is app.kubernetes.io/version, which has its value always set to .Chart.AppVersion.

This is incorrect because one might change the image tag e.g. via image.tag which will result in Gateway Pods to have app.kubernetes.io/version label set to whatever's defined in the chart but have the tag set to whatever image.tag.

Acceptance criteria

  • Decide whether we'd like to keep this Pod label or remove it
    • If the decision was to keep it, then make it consistent with whatever's set via e.g. image.tag and/or image.effectiveSemver
@pmalek pmalek added the bug Something isn't working label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant