Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kong ingress duplicate CRD installation #1051

Open
NissesSenap opened this issue Apr 10, 2024 · 2 comments
Open

kong ingress duplicate CRD installation #1051

NissesSenap opened this issue Apr 10, 2024 · 2 comments

Comments

@NissesSenap
Copy link

NissesSenap commented Apr 10, 2024

When using ArgoCD and the ingress helm chart you will get the following error
RepeatedResourceWarning Resource apiextensions.k8s.io/CustomResourceDefinition//ingressclassparameterses.configuration.konghq.com appeared 2 times among application resources.

image

I think this is because currently, ingress uses the kong helm chart as a subChart twice, but don't disable the CRD installation in the gateway.

See:

ingressController:
enabled: false

and

{{- $installCRDs := false -}}
{{- if (hasKey .Values.ingressController "installCRDs") -}}
{{/* Explicitly set, honor whatever's set */}}
{{- $installCRDs = .Values.ingressController.installCRDs -}}

I'm unsure if this actually works since we also have the folder called CRDs https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-1-let-helm-do-it-for-you, but I'm a bit unsure on how helm/argocd works in this case.

@NissesSenap
Copy link
Author

In the end, I solved this locally by setting skipCRDs on my helm chat. And I created a separate ArgoCD application that applies https://raw.githubusercontent.com/Kong/charts/6c1421bf2f4ccbd96d14eb49ed9438bbf9bef800/charts/kong/crds/custom-resource-definitions.yaml which matches the version of the CRDs in the helm chart

@rainest
Copy link
Contributor

rainest commented Apr 16, 2024

Yeah, don't know if there's anything we can do here--AFAIK there is no way to selectively disable CRDs for only one of the subcharts, and the attached issue supports that.

We want to ultimately consolidate back into a single chart, which would clear the problem. Your current workaround is what I'd suggest, with the slight difference that you should use the KIC URL for your particular controller version, which will be easier than picking out a particular chart commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants