Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various TV shows scraping methods #861

Open
Araldwenn opened this issue Jan 7, 2020 · 9 comments
Open

Various TV shows scraping methods #861

Araldwenn opened this issue Jan 7, 2020 · 9 comments

Comments

@Araldwenn
Copy link

Is your feature request related to a problem? Please describe.
When scraping TV shows, there's only the option to use aired order or DVD order. Some shows, since last TVDB API changes, have other options (https://thetvdb.com/series/la-casa-de-papel for example, has aired order and Netflix order, and I can't use Netflix order - using aired order is not an option cause there are not the same episode length nor the same episode quantity).

Describe the solution you'd like
Maybe instead of having a checkbox like "use DVD order", a scroll-down menu with the different options available could appear after clicking the scrape button

@KarellenX
Copy link

FYI TheTVDB have not yet made available those alternate orders in their API. It is currently impossible to scrape them.

IIRC even the DVD and Absolute Orders can no longer be scraped at TVDB.

See here... https://forums.thetvdb.com/viewtopic.php?p=166068#p166068

@bugwelle
Copy link
Collaborator

I'm getting tired of TheTvDb issues... 😞

Thank you @KarellenX for letting me know. I very much appreciate it. 😃

I'm surprised that you mention the DVD order. In #848 I've added tests that check for correct DVD order:

TEST_CASE("TheTvDb ShowLoader respects DVD/Official order", "[scraper][TheTvDb][load_data][requires_internet]")
{
const auto setupSpace1999 = [](TvShow& show, TvShowEpisode& episode) {
episode.setShow(&show);
episode.setSeason(SeasonNumber(1));
episode.setEpisode(EpisodeNumber(2));
show.addEpisode(&episode);
};
const auto loadSpace1999Season1Episode2 = [&setupSpace1999](bool dvdOrder, const QString& expectedTitle) {
CAPTURE(dvdOrder);
useDvdOrder(dvdOrder);
TvDbId spaceId("76366");
TvShow show;
show.setTvdbId(spaceId);
TvShowEpisode episode;
setupSpace1999(show, episode);
ShowLoader showLoader(
show, "en", {TvShowScraperInfos::Title}, {TvShowScraperInfos::Title}, TvShowUpdateType::NewEpisodes);
loadShowSync(showLoader);
showLoader.mergeEpisodesToShow();
REQUIRE(show.tvdbId() == spaceId);
CHECK(episode.name() == expectedTitle);
};
SECTION("'Space: 1999' S01E02 is loaded in DVD order")
{
loadSpace1999Season1Episode2(true, "Matter of Life and Death");
}
SECTION("'Space: 1999' S01E02 is loaded in Official order") //
{
loadSpace1999Season1Episode2(false, "Force of Life");
}
}

Those tests still works, i.e. loading in DVD order works at least partially. "Netflix"-Order and similar are not supported by MediaElch. I don't know when we will support that.

@KarellenX
Copy link

Yes, you are not the only one fed up. ;)

Ok, I am obviously mistaken regarding DVD and Absolute Orders. I was just going off memory. But it is partly broken.

If you recall, you needed the weird episode numbering like S01E01.1 and S01E01.2

Without notification, TVDB depracated that system. See here...
https://forums.thetvdb.com/viewtopic.php?p=166224#p166224

@bugwelle
Copy link
Collaborator

Oh my god... That explains so much. I had issues with episodes that are split into two parts and wondered why it didn't work anymore...

From the link you posted:

Important. This is no longer supported and will no longer be supported.

Come on... :/

@bugwelle
Copy link
Collaborator

bugwelle commented Dec 6, 2020

I won't implement it. Because TheTvDb switched to a paid model, I may remove support for it completely.

Do you know of any other sites that support different TV show orders?

@KarellenX
Copy link

TheMovieDB uses Episode Groups...
https://kodi.wiki/view/Naming_video_files/TV_shows#TheMovieDB-TV_Shows

@bugwelle
Copy link
Collaborator

bugwelle commented Dec 6, 2020

Thank you, @KarellenX ! 😄

@phmg701
Copy link

phmg701 commented Apr 3, 2022

Hello, I hope this is the right place to ask: TheMovieDB has the correct order information for the "Money Heist" (La Casa de Papel) as released on Netflix outside of Spain: https://www.themoviedb.org/tv/71446-la-casa-de-papel/episode_group/5eb730dfca7ec6001f7beb51/group/5eb730e7ca7ec6001f7beb59
Just wondering if there is a way to scrape that information into the fantastic MediaElch or if there are plans to support such information.
Thank you!

@tew42
Copy link

tew42 commented Feb 16, 2024

I just realized that TMDB would support different episode/season ordering via episode groups, and that this would be quite helpful for some series! Technically, though, this is a duplicate of #492

@bugwelle bugwelle added this to the v2.12.0 milestone Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants