Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVDB Episode thumbnails not showing up. #1740

Open
kolbdog323 opened this issue Apr 14, 2024 · 11 comments
Open

TVDB Episode thumbnails not showing up. #1740

kolbdog323 opened this issue Apr 14, 2024 · 11 comments
Labels
Milestone

Comments

@kolbdog323
Copy link

kolbdog323 commented Apr 14, 2024

Describe the bug
When you click on an episode thumbnail it doesn't show any results from the TVDB website since that is the scraper it uses when you click on an episode thumbnail. But there are episode thumbnails on the website. I think the the episode thumbnails for TVDB is broken.

@bugwelle
Copy link
Collaborator

Thanks for reporting this bug.

Did you by any chance scrape the TV series or episode already?

@bugwelle bugwelle added the component: TV shows TV shows, series, episodes label Apr 19, 2024
@bugwelle bugwelle added this to the v2.10.8 milestone Apr 19, 2024
@bugwelle bugwelle added the bug label Apr 19, 2024
@kolbdog323
Copy link
Author

Thanks for reporting this bug.

Did you by any chance scrape the TV series or episode already?

yes I did and it always says none are available no matter what episode thumbnail you click

@kolbdog323
Copy link
Author

Also a slight addition it is now showing thumbnail results for tvdb but they are for the wrong shows for example i tried to change a picture for addams family episode cousin itt visits the addams family but it didn't show a picture from that show when i clicked tvdb it showed a picture from a completely differnt show.

Here is a screenshot to show you the error.
for online

@ticao2
Copy link

ticao2 commented Apr 23, 2024

As far as I know, it is no longer possible to obtain data and images from TheTVDB using MediaElch.
See here: #1120
Did it work again?

@kolbdog323
Copy link
Author

kolbdog323 commented Apr 23, 2024

As far as I know, it is no longer possible to obtain data and images from TheTVDB using MediaElch. See here: #1120 Did it work again?

It does get images from tvdb it is able to get season posters from tvdb same with banners. Just the thumbnails is broken.

@bugwelle
Copy link
Collaborator

I never removed TheTvDb completely. Some APIs are still up and running, including for images. But as soon as they are shut down, I'll remove it for good.


If an episode was scraped, the thumbnail dialog shows the images whose URLs were scraped, and may not show other thumbnails. The only other episode thumbnail provider we currently have is TheTvDb, and that may or may not work anymore.

This is partly a feature: A new thumbnail provider, e.g. via fanart.tv

@bugwelle bugwelle modified the milestones: v2.10.8, v2.12.0 Apr 23, 2024
@bugwelle
Copy link
Collaborator

Regarding your screenshot: Did you by any chance scrape that episode or TV show wrong before? e.g. did you scrape another TV show before or did the NFO file contain URLs to to images of another show?

@kolbdog323
Copy link
Author

NO i didnt it was the fist time scraping it.

Regarding your screenshot: Did you by any chance scrape that episode or TV show wrong before? e.g. did you scrape another TV show before or did the NFO file contain URLs to to images of another show?

No i didnt it was the first time scraping it there was no nfo or anything liek that.

@bugwelle
Copy link
Collaborator

NO i didnt it was the fist time scraping it.

Ok, in your first response you stated yes I did and […]. :)

No i didnt it was the first time scraping it there was no nfo or anything liek that.

Ok, thanks.

If I remember correctly (and I could be mistaken here, it's been a long time), the thumbnail dialog only shows images once you've scraped it. The "default" image provider just looks at what the episode/TV show scraper loaded: image URLs. If they aren't there, nothing is loaded. The TheTvDb image provider no longer works (as their API and business model changed), hence there is currently no proper image provider for it.

That needs to change and the current behavior is rather confusing (which I consider a bug). :)

@kolbdog323
Copy link
Author

NO i didnt it was the fist time scraping it.

Ok, in your first response you stated yes I did and […]. :)

No i didnt it was the first time scraping it there was no nfo or anything liek that.

Ok, thanks.

If I remember correctly (and I could be mistaken here, it's been a long time), the thumbnail dialog only shows images once you've scraped it. The "default" image provider just looks at what the episode/TV show scraper loaded: image URLs. If they aren't there, nothing is loaded. The TheTvDb image provider no longer works (as their API and business model changed), hence there is currently no proper image provider for it.

That needs to change and the current behavior is rather confusing (which I consider a bug). :)

That makes no sense if its able to find tvdb banners and season posters.

@bugwelle
Copy link
Collaborator

Ok, then let me say it like that: There won't be TheTvDb support. If it works for you: Great! But it's luck whether it works or not. For me, it hasn't been working for all shows I've tested:

Screenshot_20240423_203623

There won't be a fix in the near future. I consider a new image provider to be a feature. The UI part, i.e. the inconsistent behavior, is a bug that needs fixing eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants