Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamer ignores 'Rename Directories' setting #1719

Open
2 of 5 tasks
BCVerdouw opened this issue Feb 4, 2024 · 5 comments
Open
2 of 5 tasks

Renamer ignores 'Rename Directories' setting #1719

BCVerdouw opened this issue Feb 4, 2024 · 5 comments
Labels

Comments

@BCVerdouw
Copy link

Describe the bug
Renamer ignores whether or not the "Rename Directories" option is checked or not

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Shows'
  2. Click on 'Rename selected files'
  3. Fill a random value into the 'Directory Naming' field
  4. Disable 'Rename Directories'
  5. Click 'Dry Run'
  6. See that it still tries to rename the directory.

Expected behavior
When 'Rename Directories' is disabled it should not try to rename the directories

Screenshots
If applicable, add screenshots to help explain your problem.
image
image
image

MediaElch Version:

  • 2.10.7-dev (nightly)
  • 2.10.6 (stable)

Operating System:

  • Windows
  • macOS
  • Linux (distribution: Arch)

Additional context
This is definitely a regression, seeing as it worked as intended before.

@bugwelle
Copy link
Collaborator

bugwelle commented Feb 8, 2024

Hi,

thanks for reporting this issue. Did you enable "Sep. Folders" for your TV shows in MediaElch's settings?

Regards,
Andre

@BCVerdouw
Copy link
Author

Good morning, my apologies for the late reply as i had not noticed that there was a response.

image
as you can see 'Sep. folders' is disabled on my directory with TV shows, nor do i believe i had altered any settings between when it was still working as intended and when the issue showed up.

@bugwelle
Copy link
Collaborator

Thanks. Which version did it work with? :)

IIRC, without "Sep. folders", we don't rename any folders as we are only searching recursively for movie files, but don't assume any structure, hence no renaming of directories.

Regards,
Andre

@BCVerdouw
Copy link
Author

I do not know if the same problem also exists in the movie part, as for me it happened in the TV shows, the other version I can find in the cache of my package manager is 2.10.0, but i don't recall if i ever used that version, seeing as i mostly use MediaElch to batch update new entries once in a (long) while.

@grimwiz
Copy link

grimwiz commented Apr 23, 2024

I've got the opposite problem, TV show renamer isn't renaming TV shows with this build even when I want it, for example to add the year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants