Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for separating media files per chat #93

Merged
merged 6 commits into from Apr 26, 2024

Conversation

mmmeeedddsss
Copy link

@mmmeeedddsss mmmeeedddsss commented Apr 13, 2024

I have added a flag to create a duplicate of the existing media grouped by chat.

This was my own need, and saw many people online asking for a similar ability, so I decided to open a PR in here to make that available for public use.

I have tested the change with my own backup and it is working. If you accept the PR, I'll also open another PR on the wiki section for updating the usage.

Thank you for the great repository!

@KnugiHK
Copy link
Owner

KnugiHK commented Apr 14, 2024

Hi. Thanks for your contribution first, I will review and test the changes later.

Are there any specific issues opened? If so, please let me know so that I can link the issues to this PR.

@KnugiHK KnugiHK added the enhancement New feature or request label Apr 14, 2024
@KnugiHK KnugiHK changed the base branch from main to dev April 14, 2024 15:20
@mmmeeedddsss
Copy link
Author

This was originally my own need, but I can see the following related issue too:
#88

@mmmeeedddsss
Copy link
Author

@KnugiHK Also, should I rebase my commit to dev branch and open the PR from there? Maybe it is better to test once again with my changes on top of dev branch and let you know!

@KnugiHK KnugiHK linked an issue Apr 15, 2024 that may be closed by this pull request
@KnugiHK
Copy link
Owner

KnugiHK commented Apr 15, 2024

@KnugiHK Also, should I rebase my commit to dev branch and open the PR from there? Maybe it is better to test once again with my changes on top of dev branch and let you know!

Yes, please.

@mmmeeedddsss
Copy link
Author

Hey hey !
Thank you @KnugiHK once again for your responsivness.
I just updated the base branch to dev, merged my changes to dev branch and made the necessary adjustments. It is now running on my local PC with my own android whatsapp db. (mmmeeedddsss:main now contains the KnugiHK:dev + my commit for the feature)

FYI:

  • I have mistakenly removed the LICENCE.django file you put
  • Incremented the version to 0.10.0. This is a new feature but it is backward compatible so incrementing the minor version seemed ok to me.

@KnugiHK
Copy link
Owner

KnugiHK commented Apr 15, 2024

I have mistakenly removed the LICENCE.django file you put

I will add that back later.

Incremented the version to 0.10.0. This is a new feature but it is backward compatible so incrementing the minor version seemed ok to me.

Although the PR itself cannot "own" a version, the next release will be 0.10.0, which is drafted already :), and your PR will probably be included in this version. Therefore, I will leave the version string unchange.

Btw, I read the code but I still haven't had time to test it with a database, I will finish the review ASAP.

@KnugiHK KnugiHK self-requested a review April 21, 2024 04:34
Copy link
Owner

@KnugiHK KnugiHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some changes. Could you please test it again with your database?

@destaa
Copy link

destaa commented Apr 22, 2024

I did some changes. Could you please test it again with your database?

is this works with chat group as well?

@destaa
Copy link

destaa commented Apr 22, 2024

and forgive me, I'm new in github.. as far as I know, KnugiHK has approved mmmeeedddsss's PR, and KnugiHK has commit of the new parser of --create-separated-media.
I thought I can execute the new parser with cloning KnugiHK's dev branch again, with the fresh one. But it isn't working.
What did I miss? should it be merged to dev branch first so I can execute with my database?

@KnugiHK
Copy link
Owner

KnugiHK commented Apr 22, 2024

I did some changes. Could you please test it again with your database?

is this works with chat group as well?

It should works with group chat.

I thought I can execute the new parser with cloning KnugiHK's dev branch again, with the fresh one. But it isn't working.
What did I miss? should it be merged to dev branch first so I can execute with my database?

I approved the changes but the commits are not yet being merged.

@KnugiHK
Copy link
Owner

KnugiHK commented Apr 22, 2024

@destaa If you want to try it first, install the exporter with pip install git+https://github.com/mmmeeedddsss/WhatsApp-Chat-Exporter.

@destaa
Copy link

destaa commented Apr 25, 2024

@destaa If you want to try it first, install the exporter with pip install git+https://github.com/mmmeeedddsss/WhatsApp-Chat-Exporter.

nice i'll try..thanks

@mmmeeedddsss
Copy link
Author

@KnugiHK Sorry for my late response.
Thank you for your review and patches. Also, I'm happy to see your implementation on IOS too!

The current state works well on my local database too. I think it is okay to merge this if you don't have any additional feedback or things to do.

@KnugiHK KnugiHK merged commit 9741cab into KnugiHK:dev Apr 26, 2024
@KnugiHK
Copy link
Owner

KnugiHK commented Apr 26, 2024

@KnugiHK Sorry for my late response. Thank you for your review and patches. Also, I'm happy to see your implementation on IOS too!

The current state works well on my local database too. I think it is okay to merge this if you don't have any additional feedback or things to do.

LGTM! Thanks for your contribution again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] option to choose media based on chat
3 participants