-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for separating media files per chat #93
Conversation
Hi. Thanks for your contribution first, I will review and test the changes later. Are there any specific issues opened? If so, please let me know so that I can link the issues to this PR. |
This was originally my own need, but I can see the following related issue too: |
@KnugiHK Also, should I rebase my commit to dev branch and open the PR from there? Maybe it is better to test once again with my changes on top of dev branch and let you know! |
Yes, please. |
Hey hey ! FYI:
|
I will add that back later.
Although the PR itself cannot "own" a version, the next release will be 0.10.0, which is drafted already :), and your PR will probably be included in this version. Therefore, I will leave the version string unchange. Btw, I read the code but I still haven't had time to test it with a database, I will finish the review ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some changes. Could you please test it again with your database?
is this works with chat group as well? |
and forgive me, I'm new in github.. as far as I know, KnugiHK has approved mmmeeedddsss's PR, and KnugiHK has commit of the new parser of --create-separated-media. |
It should works with group chat.
I approved the changes but the commits are not yet being merged. |
@destaa If you want to try it first, install the exporter with |
nice i'll try..thanks |
@KnugiHK Sorry for my late response. The current state works well on my local database too. I think it is okay to merge this if you don't have any additional feedback or things to do. |
LGTM! Thanks for your contribution again! |
I have added a flag to create a duplicate of the existing media grouped by chat.
This was my own need, and saw many people online asking for a similar ability, so I decided to open a PR in here to make that available for public use.
I have tested the change with my own backup and it is working. If you accept the PR, I'll also open another PR on the wiki section for updating the usage.
Thank you for the great repository!