Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kpack: Windows support #372

Open
TheElementalOfDestruction opened this issue Nov 8, 2018 · 2 comments
Open

kpack: Windows support #372

TheElementalOfDestruction opened this issue Nov 8, 2018 · 2 comments
Labels
c enhancement kpack ★ ☆ ☆

Comments

@TheElementalOfDestruction
Copy link

Exactly as the title says. If you try to build in visual studio, you get this error.

You also get a few other errors, but I'm going to be making a pull request that should fix those
@pixelherodev
Copy link

dirname is a POSIX function; POSIX specifies that it should be in libgen.h; the issue is with Microsoft.

If you want to special-case Windows, and define dirname, that's fine.

@pixelherodev pixelherodev changed the title kpack: libgen.h does not exist on Windows kpack: Windows support Aug 20, 2021
@pixelherodev
Copy link

This isn't, strictly speaking, a bug; rather, it's a portability issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c enhancement kpack ★ ☆ ☆
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelherodev @TheElementalOfDestruction