-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase max message size restriction #157
Comments
Are you sure? Once the client get authorized, we bump that size to 4GB. |
Or is it because your token/secret make that initial message pass the 512 limit? Do you know the actual size you are getting? |
Hi, A standard JWT token makes us go above the 512 limit (the hello message is around ~2.4KB). Example:
|
Ok thanks, I just wanted to double check you were using the library in the way it was intended to. |
I think:
|
Agree and you can see my comment on the associated PR to handle that. To some extent, I don't want to bump the default since it is working fine with reasonably long token. |
🎉 This issue has been resolved in version 2.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
wslink/python/src/wslink/chunking.py
Line 90 in 3508390
For example, when sending a JWT token along with a message, this size ends up too small and results in the ValueError:
wslink/python/src/wslink/chunking.py
Lines 106 to 109 in 3508390
Proposal: increase e.g.
self.max_message_size = 3000
to accommodate.The text was updated successfully, but these errors were encountered: