Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

Refactor session model/save #225

Open
mgrauer opened this issue Dec 1, 2015 · 5 comments
Open

Refactor session model/save #225

mgrauer opened this issue Dec 1, 2015 · 5 comments
Milestone

Comments

@mgrauer
Copy link
Contributor

mgrauer commented Dec 1, 2015

Right now we save the session in a few ways

  • add/remove a dataset enable the save button
  • save basemap properties through target icon
  • save basemap name/description through session edit
  • save basemap center through session edit

We should unify save methods.

Other changes:

  • currently save session in json file, instead we should use item metadata
  • change session model to extend minervamodel, use the item metadata API in minervamodel

Decide if saving the session saves session data or app state (config/layout) or just as one big blob.

@danlamanna
Copy link
Member

Additionally, use Backbone get/set. I think (but am not positive) that this event is never executed.

@mgrauer
Copy link
Contributor Author

mgrauer commented Dec 14, 2015

Be sure to bring back the ability to save the baselayer properties somehow, since they were removed in #226.

@mgrauer
Copy link
Contributor Author

mgrauer commented Dec 15, 2015

Address this comment and that comment.

@mgrauer
Copy link
Contributor Author

mgrauer commented Mar 23, 2016

Functionality related to an individual session is

  • name
  • description
  • basemap
  • choice of basemap
  • zoom level
  • center
  • currently visualized datasets
  • any color mapping/filtering/adapter properties of the visualized dataset
  • order of datasets in the stack
  • opacity of datasets

@mgrauer
Copy link
Contributor Author

mgrauer commented Mar 23, 2016

Sessions have been fixed to save in item metadata instead of a json file, in #319.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants