Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles support for MKV files #16

Open
omgbox opened this issue Nov 6, 2020 · 2 comments
Open

Subtitles support for MKV files #16

omgbox opened this issue Nov 6, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@omgbox
Copy link

omgbox commented Nov 6, 2020

found this today, might be very useful for nyaa, as many of the mkv are with subtitles that can not be played within html5. but with this, it might be possible to extract and display.

https://www.npmjs.com/package/matroska-subtitles

@KiraLT KiraLT added the enhancement New feature or request label Nov 6, 2020
@KiraLT
Copy link
Owner

KiraLT commented Nov 7, 2020

I am not sure how should it work. In theory, it could firstly load subtitles from the video and only then start streaming, but I don't think it is possible to extract subtitles without downloading the whole file.

This library can extract subtitles in real-time, but what should we do with extracted data? In theory, it is possible to re-encode MKV to MP4 and add subtitles on the screen, but I am not sure it is a good idea.

Finally, I dd found that this library works in a browser(?). At least have an example of how to include in the browser, but I can't find any example of how can it be used in a browser.

@omgbox
Copy link
Author

omgbox commented Nov 7, 2020

I am not sure how should it work. In theory, it could firstly load subtitles from the video and only then start streaming, but I don't think it is possible to extract subtitles without downloading the whole file.

This library can extract subtitles in real-time, but what should we do with extracted data? In theory, it is possible to re-encode MKV to MP4 and add subtitles on the screen, but I am not sure it is a good idea.

Finally, I dd found that this library works in a browser(?). At least have an example of how to include in the browser, but I can't find any example of how can it be used in a browser.

your totally right, i did small test on a active download mkv file with subtitle , i, tried to extract subtitles , it has created video.srt but there is zero bytes. if i leave it to download at 10% complete, there is some subtitle data extracted so, it would seem it needs to be downloaded little to get any data. does this help

@KiraLT KiraLT added the help wanted Extra attention is needed label Nov 13, 2020
@KiraLT KiraLT changed the title subtitles support for mkv files. Subtitles support for MKV files Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants