Skip to content
This repository has been archived by the owner on May 12, 2019. It is now read-only.

Make flexible add more icons #148

Open
waja opened this issue Dec 17, 2015 · 12 comments
Open

Make flexible add more icons #148

waja opened this issue Dec 17, 2015 · 12 comments

Comments

@waja
Copy link
Contributor

waja commented Dec 17, 2015

Looking into recent history of Foundation Icons it seems the development has stopped: https://github.com/zurb/foundation-icons/commits/master

Font Awesome seems to be well maintained and has a much of the recent 'brands' included:
http://fontawesome.io

related:
http://ionicons.com
http://typicons.com
https://mfglabs.github.io/mfglabs-iconset

customize:
https://icomoon.io
http://www.flaticon.com

@Kikobeats
Copy link
Owner

I don't think that this is a thing that we need (and less urgently).

Currently we get a set of commons icons. When an icon make a rebranding then is moment to think to update, but definitely this works and I'm happy to don't update code that is not broken :-)

@waja
Copy link
Contributor Author

waja commented Dec 21, 2015

The motivation of this was, that I miss some of the social networks used in the recent days.

@Kikobeats
Copy link
Owner

@waja for example? maybe is my fault because I just use twitter :P

@waja
Copy link
Contributor Author

waja commented Dec 21, 2015

For example: mixcloud, soundcloud, slack and xing. Just to name a few.

@Kikobeats Kikobeats changed the title Maybe moving over from Foundation Icon Font Set to Font Awesome Toolkit? Make flexible add more icons Dec 21, 2015
@Kikobeats
Copy link
Owner

👍

I added in your comment more links. I want to make this theme unique, so better have options :)

what do you like more? I like ionicons!

@waja
Copy link
Contributor Author

waja commented Dec 21, 2015

I've looked into them and mfglabs-iconset looks (beside fontawsome) with most social media icons. Xing (for example) is only available there.
I've suggested fortawesome, cause it looks like it has the most complete support of social icons.

@Kikobeats
Copy link
Owner

@waja ok, go ahead.

Do you think that you can conver this issue into a PR? Steps:

  1. Replace foundation reference for fontawesome.
  2. Map the same icon to the same css class fonts.
  3. Add a set of common icons missing currently.

@waja
Copy link
Contributor Author

waja commented Dec 22, 2015

As I'm not very familiar with HTML/CSS/JS I can't promise anything or that it will fit you quality standards. I'll have a look into it but ... you know. :-)

@waja
Copy link
Contributor Author

waja commented Dec 22, 2015

@Kikobeats Looked into the available icons at font-awesome. Do you think it makes sense to ship the foundation-icons AND font-awesome to not break existing customized installations?

@Kikobeats
Copy link
Owner

@waja absolutely. We have to map the new icons to the same css class for backward compatibility and add the missing icons

@Kikobeats Kikobeats reopened this Dec 22, 2015
@Kikobeats Kikobeats reopened this Dec 22, 2015
@Kikobeats
Copy link
Owner

omg, fast click :o

@waja
Copy link
Contributor Author

waja commented Dec 22, 2015

@Kikobeats Hmm ... to be honest I guess that's way above my skills in web frontend development. At least to share the outcome with others.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants