New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth server side functions #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
one to authenticate and another one to create\delete webhooks (currently I'm sending the githubToken to the client and it sends it back when creating a webhook. need to keep only the firebaseToken on the client side
thatkookooguy
added
the
feature
Everything that needs an implementation and is new
label
Aug 4, 2017
thatkookooguy
added this to the Get achievibit ready for an official 1st version milestone
Aug 4, 2017
currently, written as a comment since I need to also import the **account key** in some fancy way
private config file should make it easier to save configuration to disk (DB url, etc)
this will handle all configurations (also will save the configuration you add as argv if you add --savePrivate) I still need to make this simpler, but it's already simpler than the previous one :-)
later, should replace this with a function that does this internally
I want to change the functions inside userService to not use req and res so that it will be simpler to test. after that change, I'll change this to test the actual file and not the function I mocked a few lines before :-)
Added all |
talked with @dunaevsky about merging this in. Going to fix some of the implementation in the client side PR (notice that this shouldn't introduce any bugs since it's not hooked up to anything atm) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
currently the changes are made only on the server side