Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth server side functions #96

Merged
merged 30 commits into from Sep 29, 2017
Merged

OAuth server side functions #96

merged 30 commits into from Sep 29, 2017

Conversation

thatkookooguy
Copy link
Member

@thatkookooguy thatkookooguy commented Aug 4, 2017

Change Summary

currently the changes are made only on the server side

since our client is dumb, we need to add lot on the client so I'm doing that on a different PR

  • added some server side features for oAuth [related to oAuth #55]

introduced some bad code here, but since this is still a WIP, and since this feature is starting to be pretty big for a single PR, I'm going to continue refactoring this in future PR related as well to this feature

one to authenticate and another one to create\delete webhooks

(currently I'm sending the githubToken to the client and it sends it back when creating a webhook. need to keep only the firebaseToken on the client side
@thatkookooguy thatkookooguy added the feature Everything that needs an implementation and is new label Aug 4, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-30.2%) to 14.677% when pulling 15768f2 on auth-server into 10cd153 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.4%) to 41.42% when pulling 2465f06 on auth-server into 10cd153 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 43.349% when pulling 03e3085 on auth-server into 10cd153 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 43.349% when pulling b1340fc on auth-server into 10cd153 on master.

private config file should make it easier to save configuration to disk (DB url, etc)
this will handle all configurations (also will save the configuration you add as argv if you add --savePrivate)

I still need to make this simpler, but it's already simpler than the previous one :-)
@coveralls
Copy link

Coverage Status

Coverage decreased (-22.3%) to 22.525% when pulling 02184df on auth-server into 10cd153 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-22.4%) to 22.429% when pulling 0cce711 on auth-server into 10cd153 on master.

later, should replace this with a function that does this internally
@coveralls
Copy link

Coverage Status

Coverage decreased (-22.5%) to 22.346% when pulling cf1cbe5 on auth-server into 10cd153 on master.

I want to change the functions inside userService to not use req and res so that it will be simpler to test.

after that change, I'll change this to test the actual file and not the function I mocked a few lines before :-)
@coveralls
Copy link

Coverage Status

Coverage decreased (-22.5%) to 22.346% when pulling cb1e915 on auth-server into 10cd153 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 44.055% when pulling 80168a2 on auth-server into 10cd153 on master.

@thatkookooguy
Copy link
Member Author

thatkookooguy commented Aug 13, 2017

Added all firebase variables to our heroku ENV variables (should work once we upload this PR)

@coveralls
Copy link

Coverage Status

Coverage increased (+1.7%) to 46.552% when pulling a71bfb0 on auth-server into 10cd153 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.8%) to 39.017% when pulling fe43507 on auth-server into 10cd153 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.8%) to 39.017% when pulling 16c17fc on auth-server into 8f12be2 on master.

@thatkookooguy
Copy link
Member Author

talked with @dunaevsky about merging this in. Going to fix some of the implementation in the client side PR (notice that this shouldn't introduce any bugs since it's not hooked up to anything atm)

@thatkookooguy thatkookooguy merged commit c87b12c into master Sep 29, 2017
@thatkookooguy thatkookooguy deleted the auth-server branch November 6, 2017 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Everything that needs an implementation and is new
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants