Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
assignees
attribute instead of thereviewers
attribute on apullRequest
pull_request
events [resolves integrate the new github code review system #29]review_requested
- adds a reviewer to thepullRequest
datareview_request_removed
- removes a reviewer and adds him to the history. history for removed reviewers is not unique. that's because the same reviewer can be removed multiple timespull_request_review_comment
events [resolves integrate the new github code review system #29]created
- new review comment. add it to thereviewComments
attribute.deleted
- deleted a review comment. removes it from thereviewComments
attribute, and adds an history item insidehistory.reviewComments.deleted
with the commentid
edited
- changes the comment inreviewComments
, and adds an history item insidehistory.reviewComments[<comment_id>]
with the old message bodypull_request_review
events [resolves integrate the new github code review system #29]submitted
- reviewer submitted their review. this is populated in thereviews
attribute. This holds all reviews by all users. reviews can't be changes, so every pull request review submits a new one and adds it to the array.More info
right now, pull request review comments might appear twice! once in
reviewComments
and once ininlineComments
. So achievements that want to check all comments should go toinlineComments
and ignorereviewComments
.reviewComments
should be used for achievements that focus on code reviews.tests will be implemented in a different PR