Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional compilation is not handled correctly #3582

Open
TheMostDiligent opened this issue Apr 22, 2024 · 0 comments
Open

Conditional compilation is not handled correctly #3582

TheMostDiligent opened this issue Apr 22, 2024 · 0 comments
Labels

Comments

@TheMostDiligent
Copy link
Contributor

TheMostDiligent commented Apr 22, 2024

Compiling the following shader:

#version 430 core

void main()
{
#if 0
#   define MACROS(S) #S
#endif
}

fails with the following error :

ERROR: 0:6: '#' : (#) can be preceded in its line only by spaces or horizontal tabs 
ERROR: 0:7: '' : missing #endif 
ERROR: 0:7: '' : compilation terminated 
ERROR: 3 compilation errors.  No code generated.

This is a regression that was introduced by feb5437

@TheMostDiligent TheMostDiligent changed the title Invalid error generated from disabled code Conditional compilation is not handled correctly Apr 22, 2024
TheMostDiligent added a commit to DiligentGraphics/DiligentCore that referenced this issue Apr 23, 2024
TheMostDiligent added a commit to DiligentGraphics/glslang that referenced this issue Apr 23, 2024
TheMostDiligent added a commit to DiligentGraphics/DiligentCore that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants