Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fragment_shading_rate_dynamic crashes #913

Closed
jherico opened this issue Feb 15, 2024 · 3 comments · May be fixed by #916
Closed

fragment_shading_rate_dynamic crashes #913

jherico opened this issue Feb 15, 2024 · 3 comments · May be fixed by #916
Labels
bug Something isn't working sample This is relevant to a sample urgent Need to resolve as soon as possible

Comments

@jherico
Copy link
Contributor

jherico commented Feb 15, 2024

Building from main on Windows 10 (MSVC 2022) the fragment_shading_rate_dynamic sample currently crashes after a set of validation errors.

Output after swap chain setup is as follows:

UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_1 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_2 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_1 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_2 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_1 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_2 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_1 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_2 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_1 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_2 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
VUID-vkQueueSubmit-pCommandBuffers-00070(ERROR / SPEC): msgNum: -1360208885 - Validation Error: [ VUID-vkQueueSubmit-pCommandBuffers-00070 ] Object 0: handle = 0x2322a8bbdf0, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xaeecdc0b | VkCommandBuffer 0x2322a8bbdf0[] used in the call to vkQueueSubmit is unrecorded and contains no commands. The Vulkan spec states: Each element of the pCommandBuffers member of each element of pSubmits must be in the pending or executable state (https://vulkan.lunarg.com/doc/view/1.3.243.0/windows/1.3-extensions/vkspec.html#VUID-vkQueueSubmit-pCommandBuffers-00070)
    Objects: 1
        [0] 0x2322a8bbdf0, type: 6, name: NULL
@jherico jherico mentioned this issue Feb 15, 2024
Merged
12 tasks
@jherico
Copy link
Contributor Author

jherico commented Feb 16, 2024

Git bisect suggests that it broke with this commit: e48cc9e#diff-185d206698381bf0a1ad21ce477b6ccda43f9e7debc6d304cc2ba5aadde91f1e

@jherico jherico mentioned this issue Feb 16, 2024
Draft
13 tasks
@SaschaWillems SaschaWillems added bug Something isn't working sample This is relevant to a sample urgent Need to resolve as soon as possible labels Apr 8, 2024
@SaschaWillems
Copy link
Collaborator

Can you recheck? The sample works fine for me and I get no validation errors with the latest SDK. The layer messages seem like false positives as VK_KHR_fragment_shading_rate shouldn't require VK 1.1 or 1.2.

@SaschaWillems
Copy link
Collaborator

Checked with the latest SDK 1.3.283, and I see no validation errors and no crashes. So closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working sample This is relevant to a sample urgent Need to resolve as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fragment_shading_rate_dynamic sample jherico/Vulkan-Samples
2 participants
@jherico @SaschaWillems