Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

choose_surface_format called twice #972

Open
jherico opened this issue Mar 9, 2024 · 1 comment · May be fixed by #973 or #1041
Open

choose_surface_format called twice #972

jherico opened this issue Mar 9, 2024 · 1 comment · May be fixed by #973 or #1041
Labels
framework This is relevant to the framework

Comments

@jherico
Copy link
Contributor

jherico commented Mar 9, 2024

Vulkan-Samples/framework/core/hpp_swapchain.cpp

Line 330 in 8ba37b4

properties.surface_format = choose_surface_format(properties.surface_format, surface_formats, surface_format_priority_list);

Vulkan-Samples/framework/core/hpp_swapchain.cpp

Line 320 in 8ba37b4

properties.surface_format = choose_surface_format(properties.surface_format, surface_formats, surface_format_priority_list);

As far as I can tell, none of the parameters to the call can possibly change between the two calls.
@jherico
Copy link
Contributor Author

jherico commented Mar 9, 2024

Additionally, surface_formats and present_modes are both stored in the class, but never referenced except in this one function (with the exception of the move constructor, which doesn't really count).

Both these issues are also present in the non-hpp version of the class.

@jherico jherico linked a pull request Mar 10, 2024 that will close this issue
Open
12 tasks
@asuessenbach asuessenbach linked a pull request May 2, 2024 that will close this issue
Open
20 tasks
@SaschaWillems SaschaWillems added the framework This is relevant to the framework label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
framework This is relevant to the framework
Projects
None yet
Milestone
No milestone
2 participants
@jherico @SaschaWillems