Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requesting extension features also enables all available features #938

Open
SaschaWillems opened this issue Feb 23, 2024 · 1 comment · May be fixed by #1013
Open

Requesting extension features also enables all available features #938

SaschaWillems opened this issue Feb 23, 2024 · 1 comment · May be fixed by #1013
Labels
framework This is relevant to the framework

Comments

@SaschaWillems
Copy link
Collaborator

SaschaWillems commented Feb 23, 2024 •
edited

In a lot of samples we do something like this:

auto &requested_extension_features = gpu.request_extension_features<VkPhysicalDeviceSomeExtensionFeaturesKHR>(VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SOME_EXTENSION_FEATURES_KHR);
requested_extension_features.someFeature = VK_TRUE;

But the call to gpu.request_extension_features already sets all supported features to true by calling vkGetPhysicalDeviceFeatures2KHR, which makes the second line (enabling a feature) superfluous.

This doesn't do any harm, but it might confuse people trying to write or debug samples.
@SaschaWillems SaschaWillems added the framework This is relevant to the framework label Feb 23, 2024
@SaschaWillems SaschaWillems mentioned this issue Feb 23, 2024
Draft
19 tasks
@SaschaWillems SaschaWillems mentioned this issue Mar 11, 2024
Merged
19 tasks
@asuessenbach
Copy link
Contributor

asuessenbach commented Mar 11, 2024 •
edited

One could introduce a new function vkb::PhysicalDevice::get_extension_features<ExtensionFeatureStruct> that could be used like this:

	if (gpu.get_extension_features<VkPhysicalDeviceHostQueryResetFeaturesEXT>().hostQueryReset)
	{
		gpu.request_extension_features<VkPhysicalDeviceHostQueryResetFeaturesEXT>().hostQueryReset= VK_TRUE;
	}

... and would need to adjust all usages of request_extension_features accordingly!
... and modify request_extension_features such that it returns either an empty features struct, or the one already requested before.

@asuessenbach asuessenbach linked a pull request Apr 3, 2024 that will close this issue
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
framework This is relevant to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor getting/adding extension features to create a VkDevice with. asuessenbach/Vulkan-Samples
2 participants
@SaschaWillems @asuessenbach