Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HelloXR Vulkan version enables USE_MIRROR_WINDOW default, and it is annoying when testing it on Windows #392

Open
utzcoz opened this issue Mar 31, 2023 · 3 comments · May be fixed by #395
Open

HelloXR Vulkan version enables USE_MIRROR_WINDOW default, and it is annoying when testing it on Windows #392

utzcoz opened this issue Mar 31, 2023 · 3 comments · May be fixed by #395
Labels
synced to gitlab Synchronized to OpenXR internal GitLab

Comments

@utzcoz
Copy link
Contributor

utzcoz commented Mar 31, 2023

See https://github.com/KhronosGroup/OpenXR-SDK-Source/blob/main/src/tests/hello_xr/graphicsplugin_vulkan.cpp#L21.

From the comment, USE_MIRROR_WINDOW shows a dummy window when running Vulkan version of HelloXR on Windows platform, and this window is used for RenderDoc. As a normal tester, I don't use RenderDoc, and I just want the Runtime to display a native window to show the rendered content. What about disabling it default? If other folks want to run it with RenderDoc, they can build it with patch to enable USE_MIRROR_WINDOW macro.
@rpavlik
Copy link
Contributor

rpavlik commented Apr 4, 2023

hmm, I don't think I had actually seen this, though I guess I run CTS more often than hello XR. Seems reasonable to have it off by default, and/or make it switchable.

@utzcoz utzcoz linked a pull request Apr 5, 2023 that will close this issue
Open
@utzcoz
Copy link
Contributor Author

utzcoz commented Apr 5, 2023

@rpavlik I sent a new PR to disable it default. If developers want to debug it with RenderDoc, they can modify the code and build and run it manually.

@rpavlik-bot
Copy link
Collaborator

An issue (number 1981) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1981 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

@rpavlik-bot rpavlik-bot added the synced to gitlab Synchronized to OpenXR internal GitLab label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hello_xr: Make Vulkan's mirror window optional utzcoz/OpenXR-SDK-Source
3 participants
@rpavlik @utzcoz @rpavlik-bot