{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":4628579,"defaultBranch":"master","name":"khan-linter","ownerLogin":"Khan","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-06-11T18:29:03.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/15455?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715119033.0","currentOid":""},"activityList":{"items":[{"before":"1f15c5593d6e8a0716b7de8b53f18376da1fb264","after":"aead10d18d5b914ad46c11395d5fa03bee8fffb8","ref":"refs/heads/master","pushedAt":"2024-05-07T23:26:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"csilvers","name":"Craig Silverstein","path":"/csilvers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1445223?s=80&v=4"},"commit":{"message":"Convert all the python2 scripts to python3. (#45)\n\n## Summary:\nThere was only one!  I used `2to3` to do most of the conversion.\n\nIssue: https://khanacademy.atlassian.net/browse/INFRA-10116\n\n## Test plan:\nI ran `./add_pep8_disable_lines.py` with success.  (It ran to\ncompletion and editing a few files.)\n\nAuthor: csilvers\n\nReviewers: nathanjd\n\nRequired Reviewers:\n\nApproved By: nathanjd\n\nChecks:\n\nPull Request URL: https://github.com/Khan/khan-linter/pull/45","shortMessageHtmlLink":"Convert all the python2 scripts to python3. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2284298831\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Khan/khan-linter/issues/45\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Khan/khan-linter/pull/45/hovercard\" href=\"https://github.com/Khan/khan-linter/pull/45\">#45</a>)"}},{"before":null,"after":"fe23dbd83bb5d7d171ecc61e707a18cbbd6425b6","ref":"refs/heads/py3","pushedAt":"2024-05-07T21:57:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"csilvers","name":"Craig Silverstein","path":"/csilvers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1445223?s=80&v=4"},"commit":{"message":"Convert all the python2 scripts to python3.\n\nThere was only one!  I used `2to3` to do most of the conversion.\n\nIssue: https://khanacademy.atlassian.net/browse/INFRA-10116\n\nTest plan:\nI ran `./add_pep8_disable_lines.py` with success.  (It ran to\ncompletion and editing a few files.)","shortMessageHtmlLink":"Convert all the python2 scripts to python3."}},{"before":"8fd92c285bce1eb43edc6e98ce530b047eae97a8","after":"1f15c5593d6e8a0716b7de8b53f18376da1fb264","ref":"refs/heads/master","pushedAt":"2024-04-26T19:38:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"csilvers","name":"Craig Silverstein","path":"/csilvers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1445223?s=80&v=4"},"commit":{"message":"[🔥AUDIT🔥] Get rid of the `jobs` argbument to flake8. (#44)\n\n🖍 _This is an audit!_ 🖍\n\n## Summary:\nThis both resolves a TODO, and fixes a bug where the new version of\nflake8 expects an argparse.flag object instead of a string, and thus\nwas failing to parse this.\n\nIssue: none\n\n## Test plan:\nI ran this with success:\n```\ncd khan/internal-webserver && ka-lint gae_dashboard/initiatives.py\n```\n\nAuthor: csilvers\n\nAuditors: #infra-platform\n\nRequired Reviewers:\n\nApproved By:\n\nChecks:\n\nPull Request URL: https://github.com/Khan/khan-linter/pull/44","shortMessageHtmlLink":"[🔥AUDIT🔥] Get rid of the <code>jobs</code> argbument to flake8. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2266400390\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Khan/khan-linter/issues/44\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Khan/khan-linter/pull/44/hovercard\" href=\"https://github.com/Khan/khan-linter/pull/44\">#44</a>)"}},{"before":null,"after":"2fb732fea8ec1985883e0c076af03b3c293127f8","ref":"refs/heads/nix-jobs","pushedAt":"2024-04-26T19:38:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"csilvers","name":"Craig Silverstein","path":"/csilvers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1445223?s=80&v=4"},"commit":{"message":"Get rid of the `jobs` argbument to flake8.\n\nThis both resolves a TODO, and fixes a bug where the new version of\nflake8 expects an argparse.flag object instead of a string, and thus\nwas failing to parse this.\n\nIssue: none\n\nTest plan:\nI ran this with success:\n```\ncd khan/internal-webserver && ka-lint gae_dashboard/initiatives.py\n```","shortMessageHtmlLink":"Get rid of the <code>jobs</code> argbument to flake8."}},{"before":"b195476aebb713cde4062189e0bb4aae8a4e1bc9","after":"8fd92c285bce1eb43edc6e98ce530b047eae97a8","ref":"refs/heads/master","pushedAt":"2024-04-04T18:35:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"csilvers","name":"Craig Silverstein","path":"/csilvers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1445223?s=80&v=4"},"commit":{"message":"[🔥AUDIT🔥] Somehow when installing the new flake8, I missed committing some files. (#43)\n\n🖍 _This is an audit!_ 🖍\n\n## Summary:\nI'm not sure how.  I'm worried the `make deps` rule is not quite right\n(maybe not doing a `git add`?)  But at least this gets things working\nagain.\n\nIssue: none\n\n## Test plan:\nSuccessfully ran `git pr` in the `our-lovely-cli` repo.\n\nAuthor: csilvers\n\nAuditors: #infra-platform\n\nRequired Reviewers:\n\nApproved By:\n\nChecks:\n\nPull Request URL: https://github.com/Khan/khan-linter/pull/43","shortMessageHtmlLink":"[🔥AUDIT🔥] Somehow when installing the new flake8, I missed committing…"}},{"before":null,"after":"7e2f66c1b606a086f4f6834a49bc15718194e974","ref":"refs/heads/fix-flake8","pushedAt":"2024-04-04T18:34:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"csilvers","name":"Craig Silverstein","path":"/csilvers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1445223?s=80&v=4"},"commit":{"message":"Somehow when installing the new flake8, I missed committing some files.\n\nI'm not sure how.  I'm worried the `make deps` rule is not quite right\n(maybe not doing a `git add`?)  But at least this gets things working\nagain.\n\nIssue: none\n\nTest plan:\nSuccessfully ran `git pr` in the `our-lovely-cli` repo.","shortMessageHtmlLink":"Somehow when installing the new flake8, I missed committing some files."}},{"before":"229e73f24fd1d000d0cd3851bbf2f236c2d8c87f","after":"b195476aebb713cde4062189e0bb4aae8a4e1bc9","ref":"refs/heads/master","pushedAt":"2024-04-03T16:59:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"csilvers","name":"Craig Silverstein","path":"/csilvers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1445223?s=80&v=4"},"commit":{"message":"Fix up khan-linter to be python3-only. (#42)\n\n## Summary:\nNow that we're on python3 everywhere, we don't need `six` anymore.  Or the `vendored/py2` directory.\n\nI also changed all our shebang lines to say `python3` explicitly,\nrather than `python`.  This isn't really needed, but some folks don't\neven have a /usr/bin/python on their machine, only /usr/bin/python3!\nAnd we might as well be clear.\n\nWhile testing this, I discovered a few lint errors that are new to new\nversions of python, that I cleaned up.  I also discovered that the\nvendored pyflakes we have is too old for modern pythons, so I updated\nit, and also mccabe while I was at it.\n\nIssue: https://khanacademy.slack.com/archives/C02NMB1R5/p1710546934835669\n\n## Test plan:\n./runlint_test.py\n\nAuthor: csilvers\n\nReviewers: MiguelCastillo\n\nRequired Reviewers:\n\nApproved By: MiguelCastillo\n\nChecks:\n\nPull Request URL: https://github.com/Khan/khan-linter/pull/42","shortMessageHtmlLink":"Fix up khan-linter to be python3-only. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2192951906\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Khan/khan-linter/issues/42\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Khan/khan-linter/pull/42/hovercard\" href=\"https://github.com/Khan/khan-linter/pull/42\">#42</a>)"}},{"before":"c08a479ec4a2ff7c0a8f5e1a2347d54e70e93cd9","after":"19e8f24e69e164dd19620ed6a874406d28caf579","ref":"refs/heads/explicit-python3","pushedAt":"2024-04-01T17:00:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"csilvers","name":"Craig Silverstein","path":"/csilvers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1445223?s=80&v=4"},"commit":{"message":"upgrade flake8 and pyyaml using `make vendor_deps`","shortMessageHtmlLink":"upgrade flake8 and pyyaml using <code>make vendor_deps</code>"}},{"before":null,"after":"c08a479ec4a2ff7c0a8f5e1a2347d54e70e93cd9","ref":"refs/heads/explicit-python3","pushedAt":"2024-03-18T18:22:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"csilvers","name":"Craig Silverstein","path":"/csilvers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1445223?s=80&v=4"},"commit":{"message":"Fix up khan-linter to be python3-only.\n\nNow that we're on python3 everywhere, we don't need `six` anymore.  Or the `vendored/py2` directory.\n\nI also changed all our shebang lines to say `python3` explicitly,\nrather than `python`.  This isn't really needed, but some folks don't\neven have a /usr/bin/python on their machine, only /usr/bin/python3!\nAnd we might as well be clear.\n\nWhile testing this, I discovered a few lint errors that are new to new\nversions of python, that I cleaned up.  I also discovered that the\nvendored pyflakes we have is too old for modern pythons, so I updated\nit, and also mccabe while I was at it.\n\nIssue: https://khanacademy.slack.com/archives/C02NMB1R5/p1710546934835669\n\nTest plan:\n./runlint_test.py","shortMessageHtmlLink":"Fix up khan-linter to be python3-only."}},{"before":"9222e8f8c9aa6dead5c434d1eb7bb326207ed989","after":"229e73f24fd1d000d0cd3851bbf2f236c2d8c87f","ref":"refs/heads/master","pushedAt":"2023-09-06T21:29:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"csilvers","name":"Craig Silverstein","path":"/csilvers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1445223?s=80&v=4"},"commit":{"message":"[🔥AUDIT🔥] Replace reference to `arc lint` with `make fixc`. (#41)\n\n🖍 _This is an audit!_ 🖍\n\n## Summary:\nWe haven't used `arc` for forever!  Let's try a command that's more\nlikely to be useful.  `make fixc` doesn't exist in every repo that\nuses khan-linter, but it does in webapp, and that's a big one.\n\nIssue: https://khanacademy.slack.com/archives/C02NMB1R5/p1693959624754879\n\n## Test plan:\nNone\n\nAuthor: csilvers\n\nAuditors: benchristel\n\nRequired Reviewers:\n\nApproved By:\n\nChecks:\n\nPull Request URL: https://github.com/Khan/khan-linter/pull/41","shortMessageHtmlLink":"[🔥AUDIT🔥] Replace reference to <code>arc lint</code> with <code>make fixc</code>. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1884782905\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Khan/khan-linter/issues/41\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Khan/khan-linter/pull/41/hovercard\" href=\"https://github.com/Khan/khan-linter/pull/41\">#41</a>)"}},{"before":null,"after":"eb52209af64622c2a3168e900c0f4b9af85220df","ref":"refs/heads/no-arc-lint","pushedAt":"2023-09-06T21:29:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"csilvers","name":"Craig Silverstein","path":"/csilvers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1445223?s=80&v=4"},"commit":{"message":"Replace reference to `arc lint` with `make fixc`.\n\nWe haven't used `arc` for forever!  Let's try a command that's more\nlikely to be useful.  `make fixc` doesn't exist in every repo that\nuses khan-linter, but it does in webapp, and that's a big one.\n\nIssue: https://khanacademy.slack.com/archives/C02NMB1R5/p1693959624754879\n\nTest plan:\nNone","shortMessageHtmlLink":"Replace reference to <code>arc lint</code> with <code>make fixc</code>."}},{"before":null,"after":"b6e7494bb9dc7df09d3de54a286b351d1aa78e9e","ref":"refs/heads/flake8-bump","pushedAt":"2023-07-17T21:10:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jwiesebron","name":"James Wiesebron","path":"/jwiesebron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8340608?s=80&v=4"},"commit":{"message":"Bump flake8 version","shortMessageHtmlLink":"Bump flake8 version"}},{"before":null,"after":"38ec781a48bdcc8282c9f6a424130fce210b2ac7","ref":"refs/heads/linter-py-version","pushedAt":"2023-07-17T21:04:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jwiesebron","name":"James Wiesebron","path":"/jwiesebron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8340608?s=80&v=4"},"commit":{"message":"Update python version used to run linter","shortMessageHtmlLink":"Update python version used to run linter"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAERBSNoAA","startCursor":null,"endCursor":null}},"title":"Activity · Khan/khan-linter"}