Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace/remove PropertyMappingService #8

Open
michiproep opened this issue Oct 14, 2022 · 6 comments
Open

Replace/remove PropertyMappingService #8

michiproep opened this issue Oct 14, 2022 · 6 comments

Comments

@michiproep
Copy link

Hi @KevinDockx ,
I'm just curious if you see a problem to remove or change the PropertyMappingService since we got the same information in AutoMapper.
May-be, there is a way to utilize "mapper.ConfigurationProvider.Internal().GetAllTypeMaps()" instead of mapping all properties twice - once in profiles and once in PropertyMappingService.

Michael

@KevinDockx
Copy link
Owner

Hi Michael,

I'd actually prefer that :-) That said, I remember looking into how I could use AutoMapper for this and didn't find an intended way of achieving it... therefore I resorted to writing something myself. But if you can get it to work, by all means: use (and share ;-)) it! :)

KR,
Kevin

@Khungersumit
Copy link

Hi @michiproep

can you please check this on your end if it works? :)

#9 (comment)

@michiproep
Copy link
Author

michiproep commented Oct 20, 2022

Hi @Khungersumit , not 100% sure what you mean? Are you talking about this issue or the #9 ?
For #9 , I cannot find the class CreateAuthorRequest in the this repo, so I guess, there are more changes made in #9

@Khungersumit
Copy link

It is very hard to get a reply from @KevinDockx , He usually takes too much time to respond to the users who have subscribed to his courses 😏

#9 (comment)

@Khungersumit
Copy link

CreateAuthorRequest

Hi @michiproep

You can use your existing class, I gave my custom naming here.

Just add a new property in this XML request and the same property in your requestDto and see the Binding of new property as I expained with the screenshot in #9 (comment)
image

@KevinDockx
Copy link
Owner

It is very hard to get a reply from @KevinDockx , He usually takes too much time to respond to the users who have subscribed to his courses 😏

#9 (comment)

That's because I'm busy creating new versions of courses asked for by users ;-) But anyway, notifying me like this or on Twitter tends to do the trick - I had a look, see original post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants