Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search scrollback history feature #15

Open
julientechdev opened this issue Mar 5, 2019 · 6 comments
Open

Search scrollback history feature #15

julientechdev opened this issue Mar 5, 2019 · 6 comments

Comments

@julientechdev
Copy link

I do not know if ZSH can search scrollback history on its own, but I do know that tmux handles it.

Since I'm not using tmux on every germinal instance, could it be possible to implement a germinal scrollback search feature ?

@Keruspe
Copy link
Owner

Keruspe commented Mar 7, 2019

I consider this feature as the same kind of features as tabs / split / tiling / etc.
I don’t think it’s the terminal emulator job to do that. A terminal emulator is there to emulate a terminal: e.g. display output from the software it’s connected to.
When using tmux, it takes care of all of this.
When not using tmux, some shells might have options to do that, I guess

@julientechdev
Copy link
Author

I looked around for pure zsh alternatives, couldn't find one.
I like the idea of the separation of concerns, but I do not think it applies in this case.
Searching through previous commands and inputs are the responsability of the shell and several solutions exists.
But in this case this is a pure character displaying feature; One could see it as a gloryfied scroll, only with a param to go to the next occurrence regardless of whether this is an command input or output. Something a shell cannot do btw.

@Keruspe
Copy link
Owner

Keruspe commented Apr 4, 2019

I'll do it at some point, I just have a couple of other things to fix beforehand

@julientechdev
Copy link
Author

Gentle poke to remind about this feature, it would have saved me quite some time lately.

@annacrombie
Copy link

I agree that this feature is better handled by tmux/screen/etc. The terminal emulator imo should only emulate a terminal

@julientechdev
Copy link
Author

I beg to differ, as this feature is quite essential to most terminal usages nowadays, and it effectively couples Germinal with a terminal multiplexer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants