Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide which hyperparameters go in constructor/fit functions #15

Open
KenNewcomb opened this issue Mar 16, 2020 · 0 comments
Open

Decide which hyperparameters go in constructor/fit functions #15

KenNewcomb opened this issue Mar 16, 2020 · 0 comments

Comments

@KenNewcomb
Copy link
Owner

We could pass all parameters into the fit method, or keep fit simple (.fit(X, y)) and have all algorithm-specific parameters get passed into the constructor.

Maybe fit should have things like epochs? Only parameters associated with the actual fitting procedure?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KenNewcomb