Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugreport]: Harddepenencies on Kelp Apps not working #57

Open
DSeeLP opened this issue Apr 7, 2021 · 1 comment
Open

[bugreport]: Harddepenencies on Kelp Apps not working #57

DSeeLP opened this issue Apr 7, 2021 · 1 comment
Labels
bug Something isn't working project Fixes concerning the project structure or application management

Comments

@DSeeLP
Copy link
Contributor

DSeeLP commented Apr 7, 2021

Describe the bug

I have a kelp app which depends on another Kelp App. The depent is registered as a hard dependency. Kelp fails to enable the App with the notice that the hard dependency can not be found.

What do we have to do to reproduce this bug?

Steps to reproduce the behavior:

  1. Create 2 Kelp Apps.
  2. Hard Depent one of them.
  3. You should now see in the console when you reload that the hard dependency can not be found.

What would you expect to happen?

It should load normally.

Provide the stack trace if possible (server logs, etc.). If you can, use the debug mode for that so that debug messages are logged as well

[18:17:48 INFO]: [Kelp] [APP] Detecting KelpApplications.
[18:17:48 INFO]: [Kelp] [APP] Successfully loaded DatabaseProvider
[18:17:48 WARN]: [Kelp] [APP] Dependency DatabaseProvider (required by CityLife) is unavailable
[18:17:48 ERROR]: [Kelp] [APP] Failed to enable CityLife
[18:17:48 INFO]: [Kelp] [APP] Loading application DatabaseProvider with version 1.0

Environment information

  • Operating system: Linux Ubuntu 20.10
  • Java-Version: 11
  • Kelp-Core-Version: v.0.3.3
  • Version-Implementation: 1.8
@DSeeLP DSeeLP added the bug Something isn't working label Apr 7, 2021
@PXAV PXAV added the project Fixes concerning the project structure or application management label Apr 7, 2021
@PXAV
Copy link
Member

PXAV commented Apr 7, 2021

Thank you for the bug report! I have to admit that the dependency feature has not been tested enough to spot such errors.

In MR 0.4 I have planned to give the application management system a complete overhaul (including things like a /kelp plugins or debug command, working dependencies, etc.), where this bug would be included as well then. Before that, 0.3.4 will release with entity implementations and things like #55 fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working project Fixes concerning the project structure or application management
Projects
None yet
Development

No branches or pull requests

2 participants