Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning "Please provide display-attribute" is shown initially #277

Open
2 of 9 tasks
schnetzi opened this issue Jan 22, 2020 · 4 comments
Open
2 of 9 tasks

Warning "Please provide display-attribute" is shown initially #277

schnetzi opened this issue Jan 22, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@schnetzi
Copy link

I'm submitting a ...

  • bug report
  • feature request
  • support request

What is the current behavior?

Currently a warning is shown when v-model is missing which says [vue-simple-suggest]: Please, provide display-attribute as a key or a dotted path for a property from your object.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

I created a codesandbox where you can see that behaviour.
https://codesandbox.io/s/simple-suggest-warning-28hht?fontsize=14&hidenavigation=1&theme=dark

If you go to components/SimpleSuggest.vue and remove line 4 (v-model="inputString") you will see a warning popping up in your console. Refresh the browser and it is still there. Adding it again and refreshing the browser will solve the issue.

What is the expected behavior?

I have two different ideas:

  1. The warning message will be something more related to the problem.
  2. No warning message as it is not necessarily needed.

How are you importing Vue-simple-suggest?

  • ESNext (original code, single-file .vue component, css included) (import VueSimpleSuggest from 'vue-simple-suggest/lib')
  • ES6 (import VueSimpleSuggest from 'vue-simple-suggest')
  • ES7 and above (import VueSimpleSuggest from 'vue-simple-suggest/dist/es7')
  • Bundled version (import VueSimpleSuggest from 'vue-simple-suggest')
  • CommonJS (const VueSimpleSuggest = require('vue-simple-suggest'))
  • UMD Component (<script type="text/javascript" src="https://unpkg.com/vue-simple-suggest"></script>)

What is the motivation / use case for changing the behavior?

Let people find the problems for warnings more easily.
Keep warnings from appearing if there is no need for them.

Please tell us about your environment:

  • Vue.js Version: 2.6.11
  • Vue-simple-suggest version: 1.10.1
  • Browser: [all]
  • Language: [all]
  • Other information
    It wasn't a problem in version < 1.10
@schnetzi schnetzi changed the title Please provide display-attribute warning is showed initially Warning "Please provide display-attribute" is shown initially Jan 22, 2020
@kaskar2008
Copy link
Member

Hello, @schnetzi
We have recognized this issue as a bug and will attempt to solve it ASAP.

@kaskar2008 kaskar2008 added the bug Something isn't working label Jan 30, 2020
@goshku
Copy link

goshku commented Sep 20, 2020

What happened with that case? :)

@kaskar2008
Copy link
Member

@gstamosbg COVID has displaced our priorities :(
Looking forward to fix all the issues tho.

@vencho-mdp
Copy link

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants