Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning given when passwords are too long #2877

Open
jdaviescoates opened this issue Apr 16, 2024 · 3 comments
Open

No warning given when passwords are too long #2877

jdaviescoates opened this issue Apr 16, 2024 · 3 comments
Labels
needs-triage Needs to be triaged by a developer and assigned a release UI Primarily UI impacting

Comments

@jdaviescoates
Copy link

jdaviescoates commented Apr 16, 2024

What happened?

I tried to register on my new server and used a 128 character length password (I always do, because why not?).

No warning was given that it was too long. So then I couldn't login and had to start all over again.

What did you expect?

Really I expect to be able to use much longer passwords, but in the interim if a password of longer than 32 characters is entered a warning message should appear informing the user that 32 characters is the maximum (as I've now discovered by actually clicking on the little i to reveal this message
image

Kavita Version Number - If you don not see your version number listed, please update Kavita and see if your issue still persists.

0.8.0 - Stable

What operating system is Kavita being hosted from?

Docker (Other)

If the issue is being seen on Desktop, what OS are you running where you see the issue?

None

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

If the issue is being seen on Mobile, what OS are you running where you see the issue?

None

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

No response

Relevant log output

No response

Additional Notes

I'm running Kavita on Cloudron

@jdaviescoates jdaviescoates added the needs-triage Needs to be triaged by a developer and assigned a release label Apr 16, 2024
@majora2007 majora2007 added the UI Primarily UI impacting label Apr 16, 2024
@majora2007 majora2007 added this to To do in v0.8 - PDF & Comic Love via automation Apr 16, 2024
@lead0r
Copy link

lead0r commented Apr 26, 2024

Does that just cut everything after the 32nd character? I always wondered, why I was unable to log in, but just using the first 32 characters does not seem to work either

@majora2007
Copy link
Member

Kavita doesn't support passwords that are longer than 32 characters. So yes, it cuts off to the first 32 characters, but so does registration. When I checked the code, I see the validation on all the registration screens is there and it should show under the field like all others. I still need to validate it is doing this inline validation.

I don't really plan to support more than 32 characters, but someone can raise a PR if they feel it's really needed.

@xusiai
Copy link

xusiai commented May 8, 2024

No indication that the password was incompatible and registration appeared to complete for me. It took a few container resets to realize the password was too long.

This was with Linuxserver's v0.8.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs to be triaged by a developer and assigned a release UI Primarily UI impacting
Projects
Development

No branches or pull requests

4 participants